Re: [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in sourcing shell env

[Laszlo Ersek <lersek@redhat.com>]

Responding to this email because Thomas may not be subscribed to
edk2-devel, and edk2-devel *still* drops emails from non-subscribers
(which I think is extremely rude, see
<https://bugzilla.tianocore.org/show_bug.cgi?id=451>, but I'm really out
of devices to make the right thing happen):

On 10/18/17 10:00, Thomas Huth wrote:
> On 17.10.2017 23:12, Laszlo Ersek wrote:
>> The BuildEnv utility is sourced (executed by the user's interactive shell)
>> when the user sets up the build session. Some users like to set -C
>> (noclobber) for some additional safety in their shells, which trips up
>> BuildEnv. Update the redirection operator so that it overrides noclobber.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Thomas Huth <thuth@redhat.com>
>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>     Repo:   https://github.com/lersek/edk2.git
>>     Branch: buildenv_clobber
>>
>>  BaseTools/BuildEnv | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv
>> index f74881111c8e..ff0c5115a5e1 100755
>> --- a/BaseTools/BuildEnv
>> +++ b/BaseTools/BuildEnv
>> @@ -90,7 +90,7 @@ StoreCurrentConfiguration() {
>>    #
>>    OUTPUT_FILE=$CONF_PATH/BuildEnv.sh
>>    #echo Storing current configuration into $OUTPUT_FILE
>> -  echo "# Auto-generated by ${BASH_SOURCE[0]}" > $OUTPUT_FILE
>> +  echo "# Auto-generated by ${BASH_SOURCE[0]}" >| $OUTPUT_FILE
>>    GenerateShellCodeToSetVariable WORKSPACE $OUTPUT_FILE
>>    GenerateShellCodeToSetVariable EDK_TOOLS_PATH $OUTPUT_FILE
>>    GenerateShellCodeToUpdatePath $OUTPUT_FILE
>>
> 
> FWIW:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

So, now Thomas's R-b can be seen on the list as well.

Thank you!
Laszlo