From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 6C0D2211A6D2D for ; Fri, 14 Dec 2018 15:54:30 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB7D5EBD; Fri, 14 Dec 2018 15:54:29 -0800 (PST) Received: from supven01-VirtualBox (unknown [10.119.48.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 168213F59C; Fri, 14 Dec 2018 15:54:29 -0800 (PST) Message-ID: <7e7bee9361d2c1f2b38dc7944e82ce64a6b4a0a1.camel@arm.com> From: Supreeth Venkatesh To: Laszlo Ersek , Leif Lindholm , Andrew Fish , Michael D Kinney Cc: "edk2-devel@lists.01.org" , "Jin, Eric" Date: Fri, 14 Dec 2018 17:54:25 -0600 In-Reply-To: References: <20181212033214.10456-1-eric.jin@intel.com> <31cc8b433744850df7d65f73d3f2a6aa7840e71b.camel@arm.com> <20181214105917.qaplwp3vtspieig7@bivouac.eciton.net> <359acbc9-1e0f-722d-0096-67d77ab3c6c0@redhat.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 23:54:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2018-12-14 at 20:57 +0100, Laszlo Ersek wrote: > On 12/14/18 18:12, Supreeth Venkatesh wrote: > > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: > > > On 12/14/18 11:59, Leif Lindholm wrote: > > > > Hmm, this gets me thinking... > > > > > > > > We were discussing before about doing a line ending conversion > > > > in > > > > edk2, and let the git gools provide native line endings (as > > > > designed). > > > > > > > > Is this a good opportunity to run a pilot with edk2-test, where > > > > much > > > > less history will be lost? > > > > > > Well, history won't be lost, in the sense that people running > > > "git > > > blame" will need one more execution of "git blame" (to "look > > > past" > > > the > > > whitespace change commit), but yes, it will result in a minor > > > inconvenience. > > > > > > And, I think, converting the edk2-test repo would not be a bad > > > test > > > at all. > > > > > > > Thanks Leif/Laszlo. I volunteer to try the tool. However, I admit > > that > > I have not tried this before, any pointers/instructions on how to > > do > > this? > > I imagine you'd run a "find" command to locate all source/text files > (skip ".git"), then feed them to xargs / dos2unix. > > The trick is more in the git settings, once the internal > representation > has been converted to LF only. I'm thinking that "core.whitespace", > "am.keepcr" and "core.autocrlf" should be set the "right way". (= to > be > researched) Never mind. I think I misread the initial email. I was expecting some git tool magic or script :). I can come up with one. Thanks. > > Thanks > Laszlo