From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.45]) by mx.groups.io with SMTP id smtpd.web10.18737.1684233921329571618 for ; Tue, 16 May 2023 03:45:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=5BNOuE6c; spf=pass (domain: arm.com, ip: 40.107.6.45, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYCiH2rITJ3kwBnn5jmhksl7YjaePBHcTVG9cQSZE+A=; b=5BNOuE6c12Aizake33INCDwXiZ0MouUH0fvIPjiuKRelzDYajhjS3hQGtOKnwyur2JQCNP9LBCVfaC1X/nIdFiMYLUGtzMe8RPD8qn8ovQx0qmnzH1THv0IJ0mOEDaQXeJL2wmjyeh9Dg3Sz11W2QH0DYfUeVbTWZMpnIAL5vX8= Received: from DUZPR01CA0289.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::20) by DBBPR08MB6044.eurprd08.prod.outlook.com (2603:10a6:10:207::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 10:45:17 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b7:cafe::c0) by DUZPR01CA0289.outlook.office365.com (2603:10a6:10:4b7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Tue, 16 May 2023 10:45:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 10:45:17 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Tue, 16 May 2023 10:45:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: be08860d4c224d6c X-CR-MTA-TID: 64aa7808 Received: from b38649e4e79a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 99BE3B1B-D96D-47EC-8FDB-770EE66D7809.1; Tue, 16 May 2023 10:45:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b38649e4e79a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 May 2023 10:45:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTsWSNQwx1I7NVM+XVe1UbmMmxZcqliMYf/AAyyJGxO+AJ/VAVWiI+4apdJQrEMBVnoM5jGJ1vTYN0+BJQgEn+1iwxPPDc/xoCkgPF89/JxPRLjdy5wOMqqwjACZhwcysLB/YBLxxg5c3eKQnkCgauhjKgndTdLt9sbJ7Hg83kG/tP2NcCv5Joc2ff2W3gQbpA5EQCop/bwLZouFIvmAp5JOLvHI+PT1LTpNBloSA98iorF+PvWlyOPBj2G/FE5bTdzi16Ho4pv/oNzpWuoPRJ9xA4T9XLah5y0PSTAfha81nSiqgGPx6N7EJQSjvVcoiuMu0yGY7jckRysqrs/QrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYCiH2rITJ3kwBnn5jmhksl7YjaePBHcTVG9cQSZE+A=; b=Zvx+538it3IgLvrENq5BsfL61SM1G2TRjpz1+lZkfPSTs/Ncvx6TDmv5nF35NLaxGauZQ/jbiZPz6VF6BNCuM6YceCCkERJcUMLBLYNcH94+S48p5R6fJSNZDv98vcmBfW9aHhom0oGDg9ipbfkxMo90bZE5r8miIltk7rhvqC6f039V6vkg3nJeLRB57xshTLwETi6MB/lPlhTj8yITMaOgwhGcSLcHEKb7sYgLM6bBUzc1kygezokWi++Y5x4nwjoBe+yi6hbNFNC6bBB5+WtKYGPpRK+h+ZCT4UJufrm2eFsj5R1GBfRwJjHjZEv0W1V+cf7kI9A1K1ejGcA/SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYCiH2rITJ3kwBnn5jmhksl7YjaePBHcTVG9cQSZE+A=; b=5BNOuE6c12Aizake33INCDwXiZ0MouUH0fvIPjiuKRelzDYajhjS3hQGtOKnwyur2JQCNP9LBCVfaC1X/nIdFiMYLUGtzMe8RPD8qn8ovQx0qmnzH1THv0IJ0mOEDaQXeJL2wmjyeh9Dg3Sz11W2QH0DYfUeVbTWZMpnIAL5vX8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6055.eurprd08.prod.outlook.com (2603:10a6:20b:293::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.23; Tue, 16 May 2023 10:45:05 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6387.032; Tue, 16 May 2023 10:45:05 +0000 Message-ID: <7e89158b-7d64-a654-9ab3-adcc389c0032@arm.com> Date: Tue, 16 May 2023 11:45:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/2] Silicon/Qemu: use 64-bit Pcds for SbsaQemu GIC addresses To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki , Marcin Juszkiewicz , "nd@arm.com" References: <20230512175753.13318-1-quic_llindhol@quicinc.com> <20230512175753.13318-2-quic_llindhol@quicinc.com> From: "Sami Mujawar" In-Reply-To: <20230512175753.13318-2-quic_llindhol@quicinc.com> X-ClientProxiedBy: LO4P123CA0480.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB6055:EE_|DBAEUR03FT011:EE_|DBBPR08MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 48bf1010-9c90-442b-fdf0-08db55faa39c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sp+g2edmuFw5oCx5z5vzURzFUx8e/oGCZRZcdZFiMKkVSy1qpBVlQnhO3hhCAneV3G0Zo52omyBX90UIACZieAlgVDPvoNfZwNRWjlVhHTHW3sp33+ZyWEA3xn1dtX486opUxx1mhMNW7OtQhI3s8K42ZvWou9BhA3Wj25N/QRNhTA96WFcLHqvMB0gfyUNzi3gA0/+T/Rpv5ckH3SGVfWO0XYbv53W85MBIJEwHnQGZYcxAw2QxZtgmizloCQOalpFVaBfAsVjBipb/or5Ee5gq+iiel7mcoQbpi8BkRRO9jpzKZbyZJwdn4BMDUeLbboQtzcT+x2XlmPp98cKlH5y8TDglP1R0Yph4M12c+ZfOEZQsJdP2rCPb5Xxga4a2Y6RpRceXYvuTgS8Dy5DqEGCouFAynjSl+dMG3ntc5bA9ix9XfjvEDx1I36M8+lztmumvZhL3HiF4mNNmwpPH7HhcepEyZw7ZT3GXzTCbdQOwCnL+/48XvaBTtN4e39eeF0++8RXgq6NTw3Uo6VF7o7fqHK9uB8bQ8QDJDuPmmwReZhypeSIKBEQr964M5DjS1h2y82qNk5OYjNcmTySJpO2xbkX94s8XyKkrHmW1gId1mCeCoK7dv4AicsXYVfie2oT+fcigTTJi8vpoksmTlA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199021)(86362001)(6486002)(31696002)(36756003)(54906003)(316002)(66946007)(66556008)(478600001)(66476007)(4326008)(2906002)(44832011)(5660300002)(8936002)(8676002)(38100700002)(41300700001)(186003)(26005)(6506007)(6512007)(53546011)(83380400001)(2616005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6055 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d9532e23-bc32-4bc3-4104-08db55fa9bc1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 99n67FYMKyWv5HZIFPj5V/lR+q7pU24PWOnndp1fQND0tfYh5Vts9uj+/kOhV6IZzZuADykoAs749jWjyeB4r9PTWn4chVFmNlIpOTHePc9ufwHfG+fnqItGLu9Ld1aiComFhykjsBsaYdvjuCrEO/XRUZ6RKO+Qgh+gT65FNXhsCpMx0j/u740PDfpw0tP/aNzyXTKCtYXU3FnAVsZ7bvdWWbtMGsJCjdWvB8OKtHvzUneXRzkjH+OY0X6akv8R34zv0rC4Ggw8tAThL0y0wnMlXMnw4cc+9p6V3A/mhGHNzj4/ZhrATkM5rVdSuqH7zbpzetYcwRWst8BCAjCXqYZHKTGMIJCHBKCresxe/l71NnflFD/98z2xfpi8ey3oxs5ko+7GH7+UrWbsrd0oi3Kh0mnSu1xwszP7nrCRn2okL8i75HQsAbKrivnyDSvx/Cr/e+UhhtmfyENXyG3RXlV9+PIvO8HsT440nxw/CpfNJloqAh5BErQqPLogmMff5VgO8WH0TSOvINc3T+NjkTo7AbPQYv1cS9HgqgcJm7vN/Q8KI/BDCqKkQM1LI4pev7G1kx72QaxkmCqRwU1nZqZoP0RNcwDU4S8HL5hnO9N+Ofm15OUdnblQANuU+kk1OD5FHVbGNe9p5szSlo4GFzct7nCllrc2M/elF8f+z+xRZ7131k4mFMSJuPSztH9333xe34izxY+eAgi2gFGO79fKrkLiyAXzhHRtNA53aDw0Q8vGXW3zGZCK5RUt9u0jgJ9EPSqEsdXbaOfaHPvDaQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199021)(40470700004)(36840700001)(46966006)(54906003)(4326008)(70206006)(478600001)(70586007)(6486002)(316002)(40480700001)(82310400005)(8936002)(2906002)(8676002)(44832011)(5660300002)(82740400003)(26005)(81166007)(41300700001)(31696002)(356005)(86362001)(36756003)(2616005)(83380400001)(336012)(53546011)(186003)(6512007)(6506007)(40460700003)(47076005)(36860700001)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 10:45:17.8060 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48bf1010-9c90-442b-fdf0-08db55faa39c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6044 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/05/2023 06:57 pm, Leif Lindholm via groups.io wrote: > gArmTokenSpaceGuid.PcdGicDistributorBase and > gArmTokenSpaceGuid.PcdGicRedistributorsBase are both defined as UINT64 in > ArmPkg.dec, but SbsaQemuAcpiDxe and its exported header file use > PcdGet32. While this currently works, it will break once these Pcds are > made dynamic - so fix. > > Signed-off-by: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Graeme Gregory > Cc: Radoslaw Biernacki > Cc: Marcin Juszkiewicz > --- > Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +- > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h > index 4d5b05ba17c6..dcafcbca5a48 100644 > --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h > +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h > @@ -33,7 +33,7 @@ > EFI_ACPI_6_0_GICR, /* Type */ \ > sizeof (EFI_ACPI_6_0_GICR_STRUCTURE), /* Length */ \ > EFI_ACPI_RESERVED_WORD, /* Reserved */ \ > - FixedPcdGet32 (PcdGicRedistributorsBase), /* DiscoveryRangeBaseAddress */ \ > + FixedPcdGet64 (PcdGicRedistributorsBase), /* DiscoveryRangeBaseAddress */ \ > SBSAQEMU_MADT_GICR_SIZE /* DiscoveryRangeLength */ \ > } > > diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > index 7ba9e8e9deeb..58330a3e7005 100644 > --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > @@ -83,7 +83,7 @@ AddMadtTable ( > EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE Gicd = > EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT ( > 0, > - FixedPcdGet32 (PcdGicDistributorBase), > + FixedPcdGet64 (PcdGicDistributorBase), > 0, > 3 /* GicVersion */ > );