From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"pierre.gondois@arm.com" <pierre.gondois@arm.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
Date: Fri, 10 Apr 2020 01:43:30 +0000 [thread overview]
Message-ID: <7e9ab4a9321b4315909c34df943763fa@intel.com> (raw)
In-Reply-To: <20200330085238.43376-1-pierre.gondois@arm.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of PierreGondois
Sent: Monday, March 30, 2020 4:53 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
From: Pierre Gondois <pierre.gondois@arm.com>
The ACPI specification, version 6.3, January 2019,
defines the Named Objects Encoding for FieldElements
in section '20.2.5.2 Named Objects Encoding'.
FieldElements can be one of the following:
NamedField | ReservedField | AccessField |
ExtendedAccessField | ConnectField
Some of these keywords are starting with an opcode,
allowing to identify their type.
E.g.: ReservedField := 0x00 PkgLength
This patch adds these FieldElement opcodes definitions to
the list of AML Opcode definitions.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_v1
Notes:
v1:
- Add AML Field Element OpCodes [Pierre]
MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362843473cac5ea5856 100644
--- a/MdePkg/Include/IndustryStandard/AcpiAml.h
+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
@@ -168,4 +168,12 @@
#define AML_EXT_BANK_FIELD_OP 0x87
#define AML_EXT_DATA_REGION_OP 0x88
+//
+// FieldElement OpCode
+//
+#define AML_FIELD_RESERVED_OP 0x00
+#define AML_FIELD_ACCESS_OP 0x01
+#define AML_FIELD_CONNECTION_OP 0x02
+#define AML_FIELD_EXT_ACCESS_OP 0x03
+
#endif
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2020-04-10 1:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 8:52 [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions PierreGondois
2020-04-10 1:43 ` Zhiguang Liu [this message]
2020-04-10 3:19 ` [edk2-devel] " Liming Gao
2020-04-10 7:46 ` Sami Mujawar
2020-04-20 18:26 ` PierreGondois
2020-04-20 23:13 ` Liming Gao
[not found] <160108EF56C0475F.27565@groups.io>
2020-04-09 15:13 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9ab4a9321b4315909c34df943763fa@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox