From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.1596.1586483013374185746 for ; Thu, 09 Apr 2020 18:43:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: F4IZ9eIxgL3dtti7H9Coiyn0WutK4FnKG9lubOiokf1Wk880ZMspdqWIiyeK5KE7EoFgWiO7zO SEVnT4rdjDwQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 18:43:33 -0700 IronPort-SDR: 7asovxEoV0uYukd8g34Oy5P55Ah+DWDh7BIc4JwcLnSL6qiVFWoVMpLbi9k7eP2Xl8piAiNXgY RS7MD/V78EyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="452232949" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 09 Apr 2020 18:43:33 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:43:33 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 10 Apr 2020 09:43:30 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Fri, 10 Apr 2020 09:43:30 +0800 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "pierre.gondois@arm.com" CC: "Kinney, Michael D" , "Gao, Liming" , "Sami.Mujawar@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions Thread-Index: AQHWBnCiq0bNLrkAFEuwjjBX8baWfahxpdYg Date: Fri, 10 Apr 2020 01:43:30 +0000 Message-ID: <7e9ab4a9321b4315909c34df943763fa@intel.com> References: <20200330085238.43376-1-pierre.gondois@arm.com> In-Reply-To: <20200330085238.43376-1-pierre.gondois@arm.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: zhiguang.liu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhiguang Liu -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Pier= reGondois Sent: Monday, March 30, 2020 4:53 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; Kinney, Michael D ; Gao, Liming ; Sami.Mujawar@arm.com= ; nd@arm.com Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode defi= nitions From: Pierre Gondois The ACPI specification, version 6.3, January 2019, defines the Named Objects Encoding for FieldElements in section '20.2.5.2 Named Objects Encoding'. FieldElements can be one of the following: NamedField | ReservedField | AccessField | ExtendedAccessField | ConnectField Some of these keywords are starting with an opcode, allowing to identify their type. E.g.: ReservedField :=3D 0x00 PkgLength This patch adds these FieldElement opcodes definitions to the list of AML Opcode definitions. Signed-off-by: Pierre Gondois --- The changes can be seen at https://github.com/PierreARM/edk2/commits/695_A= dd_FieldElement_OpCode_v1 Notes: v1: - Add AML Field Element OpCodes [Pierre] MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/In= dustryStandard/AcpiAml.h index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a0437936284= 3473cac5ea5856 100644 --- a/MdePkg/Include/IndustryStandard/AcpiAml.h +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h @@ -168,4 +168,12 @@ #define AML_EXT_BANK_FIELD_OP 0x87 #define AML_EXT_DATA_REGION_OP 0x88 =20 +// +// FieldElement OpCode +// +#define AML_FIELD_RESERVED_OP 0x00 +#define AML_FIELD_ACCESS_OP 0x01 +#define AML_FIELD_CONNECTION_OP 0x02 +#define AML_FIELD_EXT_ACCESS_OP 0x03 + #endif --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'