Re: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

[Laszlo Ersek <lersek@redhat.com>]

On 08/07/18 14:23, Laszlo Ersek wrote:
> On 08/07/18 07:27, Gao, Liming wrote:
>> Laszlo:
>>   I mean to keep the minimal change in PCCT. I don't prevent the necessary change in PCCT code. Per your comments, this change in PCCT is necessary. If so, I am OK to this patch. 
>>
>>   Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> Thanks -- I understand it better now. I will return to the RHBZ and
> discuss the PCCTS question with the requestors. I will explain your
> preference. If they feel it's really necessary to build PCCTS (antlr and
> dlg) with the additional flags, even just for generating the lexer and
> the parser for VfrCompile, I'll go ahead with your R-b for all six
> patches. If they agree the PCCTS build can ignore the flags, I won't
> modify PCCTS.
> 
> Thank you for taking the time to discuss this! I'll report back.

I will soon submit a v2 that does not touch the PCCTS (antlr & dlg)
build flags.

Thanks!
Laszlo