From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.8822.1579516052700706820 for ; Mon, 20 Jan 2020 02:27:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MeL80dFB; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579516051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xcGIoDZ+j1+tDe1fla7O0Cc9iCYZFTcFj9XQU4BZzVg=; b=MeL80dFB4TiF/qEIE3GsS9KHo5YRuhiC+6JEt/q+Ba73jW6EMuerrCG9VfWJlDfGb3Q2X7 a85avNI9jd+wbSib0134eg0GOM9no9dM2o7ajVc46tSnmUoqMkBCpYwVfN0ml6UnEVF98y FdoReU8NWC5qVqTnDbCIhirAzZCXFYQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-9tBsPZfkPryzvMdw81IkLQ-1; Mon, 20 Jan 2020 05:27:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4477410054E3; Mon, 20 Jan 2020 10:27:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-50.ams2.redhat.com [10.36.117.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D9FF8478B; Mon, 20 Jan 2020 10:27:24 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length To: devel@edk2.groups.io, philmd@redhat.com, "Feng, Bob C" Cc: "Gao, Liming" , "Justen, Jordan L" , "Zhu, Yonghong" , "Gao, Zhichao" References: <20200102121656.29572-1-philmd@redhat.com> <08650203BA1BD64D8AD9B6D5D74A85D1615A09AE@SHSMSX104.ccr.corp.intel.com> <79341b5f-e604-4455-d812-4617ff403a72@redhat.com> From: "Laszlo Ersek" Message-ID: <7ea32675-bd23-287c-8cfd-730c403c8f03@redhat.com> Date: Mon, 20 Jan 2020 11:27:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <79341b5f-e604-4455-d812-4617ff403a72@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 9tBsPZfkPryzvMdw81IkLQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/20/20 10:11, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Liming, >=20 > On 1/9/20 6:35 AM, Feng, Bob C wrote: >> Reviewed-by: Bob Feng >=20 > Is the Review-by tag from Bob enough to get this patch merged? Yes, see the "M" role: BaseTools F: BaseTools/ W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools M: Bob Feng M: Liming Gao ... In fact, the patch has been committed as 2649a735b249e. Unfortunately: - your name has been messed up in the "Author" meta-datum :( - we don't directly know who committed the patch, becaus "Committer" only says "mergify[bot]" Now, based on the subject and the commit date of the patch, I can find some related notification emails in my "github.com email notifications" folder. From those, the revelant (merged) GitHub PR seems to be: https://github.com/tianocore/edk2/pull/283 I agree it's annoying to not have confirmation on the mailing list, directly in your patch's thread. The only thing I can recommend is, check the git history periodically, for recently committed patches, authored by yourself. Personally, on the maintainer side, I always make sure to confirm a merge on-list, separately. Thanks Laszlo