From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.388.1588110998578170285 for ; Tue, 28 Apr 2020 14:56:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dkjip2MX; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588110997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=445HqZBsayAmO7Kk3A1eYzU2wZSRAH1W3N/GUbBpyJI=; b=dkjip2MXDy/v/m/a/hArByz9eiL9JBRf84c6WovR7+Fxi8gSo+glaiElpQJxWyHEEwx2rd /QcFaznYXHQ7mvkTPAhDzRu4MeKAsV5166bhz+9TTiR3e+Bx4aYu4tsm3bgzLnO+CEZnGe dGVsH2Q0FPHoNOMw2wOdoJmpEJsIyRQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-QHqxic2bNoeOlIFs4XSylw-1; Tue, 28 Apr 2020 17:56:29 -0400 X-MC-Unique: QHqxic2bNoeOlIFs4XSylw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46A8F468; Tue, 28 Apr 2020 21:56:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-33.ams2.redhat.com [10.36.113.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4430C1002395; Tue, 28 Apr 2020 21:56:27 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure To: edk2-devel-groups-io , eric.dong@intel.com Cc: Ray Ni , Chandana Kumar References: <20200424084716.877-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: <7eae289b-d796-0582-25cf-937c1cc98751@redhat.com> Date: Tue, 28 Apr 2020 23:56:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200424084716.877-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/24/20 10:47, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 > > This patch serial used to fix an ASSERT issue. Because AP can't find > the CpuMpData through IDT, it raised the ASSERT. > > V3: > 1. Remove invalid save Volatile Registers process. Refine restore > Volatile Registers process. > > V2: > 1. Enhance code comments. > 2. Enhance code to remove CpuMpData->ApLoopMode == ApInHltLoop check. > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Chandana Kumar > > > Eric Dong (2): > UefiCpuPkg/MpInitLib: Restore IDT context for APs. > UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI. > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 47 ++++++++++++++++++++-------- > 1 file changed, 34 insertions(+), 13 deletions(-) > I plan to regression-test this series with OVMF tomorrow. Thanks for your patience! Laszlo