From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com, "Zhang,
Qi1" <qi1.zhang@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox
Date: Wed, 17 Mar 2021 19:28:07 +0100 [thread overview]
Message-ID: <7eb2c787-1236-da0d-3257-1068c3411a16@redhat.com> (raw)
In-Reply-To: <DF214EE5-6641-42DB-AE18-1442F13BAC11@intel.com>
On 03/17/21 05:19, Yao, Jiewen wrote:
> Thank you Qi.
>
> i recommend we file a bugzilla on the scope of the problem
I agree.
We already have a number of BZs related to the disablement of SHA1 and MD5:
https://bugzilla.tianocore.org/show_bug.cgi?id=1682
https://bugzilla.tianocore.org/show_bug.cgi?id=2943
https://bugzilla.tianocore.org/show_bug.cgi?id=3003
https://bugzilla.tianocore.org/show_bug.cgi?id=3021
https://bugzilla.tianocore.org/show_bug.cgi?id=3027
https://bugzilla.tianocore.org/show_bug.cgi?id=3079
We should certainly track the change for Tcg2Config too, in a new BZ.
Thanks
Laszlo
>
> After the scope is agreed, then you can send the patch.
>
> For example, I can ask why not remove the sha1supported field at all?
>
> I hope the community can reach consensus on the problem statement at first.
>
>
> thank you!
> Yao, Jiewen
>
>
>> 在 2021年3月17日,上午10:56,Zhang, Qi1 <qi1.zhang@intel.com> 写道:
>>
>> wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES.
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Qi Zhang <qi1.zhang@intel.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
>> ---
>> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
>> index 2946f95db0..81a4d3fa6a 100644
>> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
>> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
>> @@ -710,9 +710,11 @@ SetConfigInfo (
>> )
>> {
>> switch (TpmAlgHash) {
>> +#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES
>> case TPM_ALG_SHA1:
>> Tcg2ConfigInfo->Sha1Supported = TRUE;
>> break;
>> +#endif
>> case TPM_ALG_SHA256:
>> Tcg2ConfigInfo->Sha256Supported = TRUE;
>> break;
>> --
>> 2.26.2.windows.1
>>
>
>
>
>
>
next prev parent reply other threads:[~2021-03-17 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 2:56 [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox Qi Zhang
2021-03-17 4:19 ` Yao, Jiewen
2021-03-17 18:28 ` Laszlo Ersek [this message]
[not found] ` <MW4PR21MB1907F79198F1509C702A708CEF6A9@MW4PR21MB1907.namprd21.prod.outlook.com>
2021-03-18 4:46 ` [EXTERNAL] Re: [edk2-devel] " Qi Zhang
2021-03-18 23:56 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb2c787-1236-da0d-3257-1068c3411a16@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox