Re: [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Replace EfiResetSystemLib with ResetSystemLib

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pranav,

Apologies for the delay.

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 05/04/2022 07:48 am, Pranav Madhu wrote:
> Replace EfiResetSystemLib library with ResetSystemLib library. UEFI
> ResetSystem() API is implemented in both these libraries, and the
> implementation is also similar. The code for EfiResetSystemLib will be
> removed from edk2. Update the platform build description files by
> replacing EfiResetSystemLib with ResetSystemLib.
>
> Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> ---
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 4 ++--
>   Platform/ARM/SgiPkg/SgiPlatform.fdf     | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> Link to github branch for this patch -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_resetlib
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 582efb0114c6..fd7fb11238d6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -32,11 +32,11 @@
>     ArmPlatformSysConfigLib|Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf
>     ArmPlatformLib|Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf
>     BasePathLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> -  EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
>     LcdHwLib|ArmPlatformPkg/Library/HdLcd/HdLcd.inf
>     LcdPlatformLib|Platform/ARM/SgiPkg/Library/HdLcdArmSgiLib/HdLcdArmSgiLib.inf
>     NorFlashPlatformLib|Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf
>     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> +  ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>     TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
>   !if $(SECURE_BOOT_ENABLE) == TRUE
>     MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> @@ -258,10 +258,10 @@
>     ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>     EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>     EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
> -  EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
>     MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
>     MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
>     MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> +  MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
>   !if $(SECURE_BOOT_ENABLE) == TRUE
>     MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf {
>       <LibraryClasses>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> index 21eeb3706ba0..4018480b424c 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> @@ -87,10 +87,10 @@ READ_LOCK_STATUS   = TRUE
>     INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf
>     INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
>     INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> -  INF EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
>     INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
>     INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
>     INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> +  INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
>     INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
>   !if $(SECURE_BOOT_ENABLE) == TRUE
>     INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf