Re: [PATCH v5 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

[Laszlo Ersek <lersek@redhat.com>]

On 04/07/17 08:25, Phil Dennis-Jordan wrote:
> From: Phil Dennis-Jordan <phil@philjordan.eu>
> 
> In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements
> a basic version of VMWare's SVGA display device. Drivers for this
> device exist for some guest OSes which do not support Qemu's other
> display adapters, so supporting it in OVMF is useful in conjunction
> with those OSes.
> 
> This change adds support for the SVGA device's framebuffer to
> QemuVideoDxe's graphics output protocol implementation, based on
> VMWare's documentation. The most basic initialisation, framebuffer
> layout query, and mode setting operations are implemented.
> 
> The device relies on port-based 32-bit I/O, unfortunately on misaligned
> addresses. This limits the driver's support to the x86 family of
> platforms.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
> ---
> 
> Notes:

>     v5:
>     - Removed duplicate hw register read in QemuVideoVmwareSvgaModeSetup. [Laszlo]
>     - Fixed memory leak of VMWare SVGA specific modelist. [Laszlo]

Phil, I considered these changes minor enough for you to carry forward
Jordan's and my R-b from version 4. I did think a separate v5 was going
to be best, but I figured a quick inter-diff before committing v5 would
be sufficient from my side or Jordan's (with the carried forward R-b's).

With that in mind (and also given that Jordan actually commented on the
dupe register read, before giving his R-b for v4), I have now carried
forward both R-b's from v4 to this patch, after verifying the v5 updates:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

I hope that's fine with you, Jordan -- I wanted neither to delay this
series any longer (I promised Phil Friday and he's been very quick to
address our observations) nor to lose your R-b. Again, I think the
changes are minor enough to preserve our R-b's from v4.

Series pushed as 59a36f21ac2b..c137d9508169.

Phil, thanks for the contribution,
Laszlo