From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08E712194235C for ; Fri, 7 Apr 2017 03:46:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68D8FC049D5C; Fri, 7 Apr 2017 10:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 68D8FC049D5C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 68D8FC049D5C Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-118.phx2.redhat.com [10.3.116.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46D8FA60A4; Fri, 7 Apr 2017 10:46:09 +0000 (UTC) To: Phil Dennis-Jordan , Jordan Justen References: <1491546358-58572-1-git-send-email-lists@philjordan.eu> <1491546358-58572-4-git-send-email-lists@philjordan.eu> Cc: edk2-devel@lists.01.org, Phil Dennis-Jordan From: Laszlo Ersek Message-ID: <7eca0d29-c1a7-a8f0-4611-6e052ecc947d@redhat.com> Date: Fri, 7 Apr 2017 12:46:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491546358-58572-4-git-send-email-lists@philjordan.eu> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 07 Apr 2017 10:46:10 +0000 (UTC) Subject: Re: [PATCH v5 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 10:46:11 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/07/17 08:25, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements > a basic version of VMWare's SVGA display device. Drivers for this > device exist for some guest OSes which do not support Qemu's other > display adapters, so supporting it in OVMF is useful in conjunction > with those OSes. > > This change adds support for the SVGA device's framebuffer to > QemuVideoDxe's graphics output protocol implementation, based on > VMWare's documentation. The most basic initialisation, framebuffer > layout query, and mode setting operations are implemented. > > The device relies on port-based 32-bit I/O, unfortunately on misaligned > addresses. This limits the driver's support to the x86 family of > platforms. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Phil Dennis-Jordan > --- > > Notes: > v5: > - Removed duplicate hw register read in QemuVideoVmwareSvgaModeSetup. [Laszlo] > - Fixed memory leak of VMWare SVGA specific modelist. [Laszlo] Phil, I considered these changes minor enough for you to carry forward Jordan's and my R-b from version 4. I did think a separate v5 was going to be best, but I figured a quick inter-diff before committing v5 would be sufficient from my side or Jordan's (with the carried forward R-b's). With that in mind (and also given that Jordan actually commented on the dupe register read, before giving his R-b for v4), I have now carried forward both R-b's from v4 to this patch, after verifying the v5 updates: Reviewed-by: Laszlo Ersek Reviewed-by: Jordan Justen I hope that's fine with you, Jordan -- I wanted neither to delay this series any longer (I promised Phil Friday and he's been very quick to address our observations) nor to lose your R-b. Again, I think the changes are minor enough to preserve our R-b's from v4. Series pushed as 59a36f21ac2b..c137d9508169. Phil, thanks for the contribution, Laszlo