Re: [PATCH 1/2] ArmVirtPkg: enable HttpDynamiCommand

["Laszlo Ersek" <lersek@redhat.com>]

Hi Vladimir,

On 07/21/20 19:23, Vladimir Olovyannikov wrote:
> Enable HttpDynamicCommand (http Shell command)
> 
> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index cf44fc73890b..c7d52175ee37 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -377,6 +377,12 @@ [Components.common]
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>    }
> +
> +  ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +  }
> +
>    OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> --
> 2.26.2.266.ge870325ee8
> 

thank you very much for this series. My comments (for this patch):

(1) Please mention <https://bugzilla.tianocore.org/show_bug.cgi?id=2857>
in the commit message.

(2) The currently enabled dynamic commands "TftpDynamicCommand" and
"LinuxInitrdDynamicShellCommand.inf" do not have any empty lines between
them in the "ArmVirtPkg/ArmVirt.dsc.inc" file. Please insert the new
code block similarly (no leading or trailing empty lines).

(3) Updating the "ArmVirtPkg/ArmVirt.dsc.inc" file makes sure that the
code will be built, but that's not enough for including the module in
the firmware binaries. Please locate "TftpDynamicCommand" in the
following additional files:

- ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
- ArmVirtPkg/ArmVirtXen.fdf

and insert HttpDynamicCommand in those files too, right after
"TftpDynamicCommand".

Thanks!
Laszlo