From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web12.27316.1595447251787350300
 for <devel@edk2.groups.io>;
 Wed, 22 Jul 2020 12:47:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S8Csx0q4;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1595447250;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fwGBwFcZIgBV1i6eKpQhPTr6qWxazCxwRDd5M/IQRSo=;
	b=S8Csx0q42kYILlbD7t1triOoOkHfCT7QtyG89pAh37zRcB03gBTzMhw+199bgF/hKtGkoX
	Uk4303glxIvtfWur6kYoj5UOJAbMMctOLgQkV3+qm9sqKGWXQDQ8b8UhbxJFwGPV5Ve5Kw
	EE1EQmn/uj2zIl45oh935QQoj/toFfo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-415-B9VbWd6BN6CHwLJ-VbqynQ-1; Wed, 22 Jul 2020 15:47:24 -0400
X-MC-Unique: B9VbWd6BN6CHwLJ-VbqynQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86ADD80BCAC;
	Wed, 22 Jul 2020 19:47:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-129.ams2.redhat.com [10.36.113.129])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 754765D9D3;
	Wed, 22 Jul 2020 19:47:22 +0000 (UTC)
Subject: Re: [PATCH 1/2] ArmVirtPkg: enable HttpDynamiCommand
To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
 devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200721172305.9011-1-vladimir.olovyannikov@broadcom.com>
 <20200721172305.9011-2-vladimir.olovyannikov@broadcom.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7f054a30-e080-37af-6761-166e97dd7788@redhat.com>
Date: Wed, 22 Jul 2020 21:47:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200721172305.9011-2-vladimir.olovyannikov@broadcom.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi Vladimir,

On 07/21/20 19:23, Vladimir Olovyannikov wrote:
> Enable HttpDynamicCommand (http Shell command)
> 
> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index cf44fc73890b..c7d52175ee37 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -377,6 +377,12 @@ [Components.common]
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>    }
> +
> +  ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +  }
> +
>    OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> --
> 2.26.2.266.ge870325ee8
> 

thank you very much for this series. My comments (for this patch):

(1) Please mention <https://bugzilla.tianocore.org/show_bug.cgi?id=2857>
in the commit message.

(2) The currently enabled dynamic commands "TftpDynamicCommand" and
"LinuxInitrdDynamicShellCommand.inf" do not have any empty lines between
them in the "ArmVirtPkg/ArmVirt.dsc.inc" file. Please insert the new
code block similarly (no leading or trailing empty lines).

(3) Updating the "ArmVirtPkg/ArmVirt.dsc.inc" file makes sure that the
code will be built, but that's not enough for including the module in
the firmware binaries. Please locate "TftpDynamicCommand" in the
following additional files:

- ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
- ArmVirtPkg/ArmVirtXen.fdf

and insert HttpDynamicCommand in those files too, right after
"TftpDynamicCommand".

Thanks!
Laszlo