From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.11226.1686235882488736870
 for <devel@edk2.groups.io>;
 Thu, 08 Jun 2023 07:51:22 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=j6SfnTSg;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 98C5720C145B;
	Thu,  8 Jun 2023 07:51:21 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 98C5720C145B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1686235882;
	bh=mNFaisZadz2nysaO+RXvkJXev85TQOiTF0O2WAL5SII=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=j6SfnTSgDimcF5VvuDsb4AacV6k3hrdZagBIlK7yPH4mrBTZFCanlQEcLGGlImxip
	 o6c/mLOZgapzHbmoI74f7r9jRCPT0jdpNJdwI4ifywj2DdxX+u7SxucKdb8V5pnG6M
	 HnSYvGxj9JmD52PYci29jNtt9EbewAzArhbOBMwY=
Message-ID: <7f1600f7-1b1f-afc2-2c6e-8ada4642a0eb@linux.microsoft.com>
Date: Thu, 8 Jun 2023 10:51:20 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [edk2-devel] [PATCH 2/4] PrmPkg: Use new API to replace MtrrLibInitializeMtrrMask
To: devel@edk2.groups.io, zhiguang.liu@intel.com
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
References: <20230608030629.2734-1-zhiguang.liu@intel.com>
 <20230608030629.2734-2-zhiguang.liu@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230608030629.2734-2-zhiguang.liu@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Minor comment in code below.

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/7/2023 11:06 PM, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394
> 
> The function MtrrLibInitializeMtrrMask is a private function
> in MtrrLib.c from UefiCpuPkg, and it can be replace with new
> API GetMaxPlatformAddressBits.
> 
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>   .../PrmSampleHardwareAccessModule.c            | 18 ++----------------
>   .../PrmSampleHardwareAccessModule.inf          |  1 +
>   2 files changed, 3 insertions(+), 16 deletions(-)
> 
> diff --git a/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.c b/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.c
> index 1a1e735029..398497c3a9 100644
> --- a/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.c
> +++ b/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.c
> @@ -13,6 +13,7 @@
>   #include <Library/BaseLib.h>
>   #include <Library/MtrrLib.h>
>   #include <Library/UefiLib.h>
> +#include <Library/CpuLib.h>
>   
>   #include <Register/Intel/ArchitecturalMsr.h>
>   #include <Register/Intel/Cpuid.h>
> @@ -37,21 +38,6 @@
>   //
>   extern CONST CHAR8  *mMtrrMemoryCacheTypeShortName[];
>   
> -/**
> -  Initializes the valid bits mask and valid address mask for MTRRs.
> -
> -  This function initializes the valid bits mask and valid address mask for MTRRs.
> -
> -  @param[out]  MtrrValidBitsMask     The mask for the valid bit of the MTRR
> -  @param[out]  MtrrValidAddressMask  The valid address mask for the MTRR
> -
> -**/
> -VOID
> -MtrrLibInitializeMtrrMask (
> -  OUT UINT64  *MtrrValidBitsMask,
> -  OUT UINT64  *MtrrValidAddressMask
> -  );
> -
>   /**
>     Convert variable MTRRs to a RAW MTRR_MEMORY_RANGE array.
>     One MTRR_MEMORY_RANGE element is created for each MTRR setting.
> @@ -151,7 +137,7 @@ AccessAllMtrrs (
>     MtrrGetAllMtrrs (&LocalMtrrs);
>     Mtrrs = &LocalMtrrs;
>   
> -  MtrrLibInitializeMtrrMask (&MtrrValidBitsMask, &MtrrValidAddressMask);
> +  GetMaxPlatformAddressBits (&MtrrValidBitsMask, &MtrrValidAddressMask);
>     Ranges[0].BaseAddress = 0;
>     Ranges[0].Length      = MtrrValidBitsMask + 1;
>     Ranges[0].Type        = MtrrGetDefaultMemoryType ();
> diff --git a/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.inf b/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.inf
> index 46d4a88185..b15da817c1 100644
> --- a/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.inf
> +++ b/PrmPkg/Samples/PrmSampleHardwareAccessModule/PrmSampleHardwareAccessModule.inf
> @@ -34,6 +34,7 @@
>     MtrrLib
>     UefiDriverEntryPoint
>     UefiLib
> +  CpuLib

Since the library class list was already sorted, can you please sort 
CpuLib within the list?

>   
>   [Depex]
>     TRUE