From: "Anthony PERARD" <anthony.perard@citrix.com>
To: "Corvin Köhne" <corvink@freebsd.org>
Cc: <devel@edk2.groups.io>, Gerd Hoffmann <kraxel@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH v5 1/3] OvmfPkg/Xen: export search of RSDP into a library function
Date: Thu, 11 May 2023 14:30:23 +0100 [thread overview]
Message-ID: <7f1ffbdb-89d1-4e18-a220-28f61c282f8f@perard> (raw)
In-Reply-To: <20230511120239.695237-1-corvink@FreeBSD.org>
On Thu, May 11, 2023 at 02:02:37PM +0200, Corvin Köhne wrote:
> diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c
> new file mode 100644
> index 000000000000..ce52ad31cf25
> --- /dev/null
> +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c
> @@ -0,0 +1,62 @@
> +/** @file
> + Copyright (c) 2023, Corvin Köhne <corvink@FreeBSD.org>
As this new file move codes from OvmfPkg/XenAcpiPlatformDxe/Xen.c,
shouldn't you also copy the "Copyright" lines from that file as well?
Beside that, patch looks fine:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2023-05-11 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 12:02 [PATCH v5 1/3] OvmfPkg/Xen: export search of RSDP into a library function Corvin Köhne
2023-05-11 12:02 ` [PATCH v5 2/3] OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib Corvin Köhne
2023-05-11 13:04 ` [edk2-devel] " Rebecca Cran
2023-05-11 13:16 ` Corvin Köhne
2023-05-11 13:19 ` Ard Biesheuvel
2023-05-11 13:47 ` Rebecca Cran
2023-05-12 1:47 ` 回复: " gaoliming
2023-05-11 13:45 ` Anthony PERARD
2023-05-11 12:02 ` [PATCH v5 3/3] OvmfPkg/Bhyve: install ACPI tables from memory Corvin Köhne
2023-05-11 13:30 ` Anthony PERARD [this message]
2023-06-01 15:01 ` [edk2-devel] [PATCH v5 1/3] OvmfPkg/Xen: export search of RSDP into a library function Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f1ffbdb-89d1-4e18-a220-28f61c282f8f@perard \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox