From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by mx.groups.io with SMTP id smtpd.web11.59031.1683811830672518718 for ; Thu, 11 May 2023 06:30:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=OQ0U3d7j; spf=pass (domain: citrix.com, ip: 216.71.155.144, mailfrom: prvs=488542a2a=anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683811830; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=PZhbBso/mxwjs9qyJrZQkfT/EuR3lTKMWZDxgC/Z54s=; b=OQ0U3d7j/70QOJLYo5BYLART6+DI4LbgpZHelMjBFx+dG+cUpIJQM7W9 sOKYb/NKVT7Pw7bghxnuLk8EpabaMHouBdsrkAfqQtWMFv9ARq7QIWobL +JjN7fibm1J2wqhj4LO/f17M05692QTjswZvVeghC9MtveBlxl6iwauRS 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 111128015 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:OENEA6Il8Us1EX13FE+RLpUlxSXFcZb7ZxGr2PjKsXjdYENS1jUDz zFOCjrVPazfMGf9fY11bY7joE0BupTRz4BiHVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wVnPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5eEURE3 +0gDAwhRT3YvMvmg5ulS/ZF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJwMxBbA/ z+uE2LRAzMILvyj42K8zkmxhdbLoA3DRKEQPejtnhJtqALKnTFCYPEMbnOwpuOni0i9c9xFJ kEe4SZoqrI9nGSnQ8fwWzW1rH3e+BEGXMdICKs772mlybDd8wudLnIJQj5IdJots8pebTUw2 lXKg9LgAztkt6eYYXGQ7LGZqXW1Iyd9BW0DaDAJS00U6t7LoYcvgxaJRdFmeIa3icf5EDe2x 3aIsTMiirM7jMgX2qH99lfC6xquu5zIQwgd9gjRGGW/4WtRbZaofYWy5XDH7PxLK8CSSVzpg ZQfs5HAtqZUV8jLzXHTBrxXR9lF+sppLhX1kXtlNYgZ0wiB0FP4RqkAoxhgJVhAZ5NslSDSX GffvgZY5Zl2NXSsbLNqb4/ZN/nG3ZQMBvy+CKmKM4MmjoxZMVbeoXowPRL4M3XFyhBErE0pB XuMnS9A514+AL8v8je5Tvx1PVQDlnFnnjO7qXwWIn2aPVuiiJy9E+9t3LimNLpRAEa4TOL9r L5i2zOikUk3bQEHSnC/HXQvBV4LN2MnIpv9ttZacOWOSiI/RjF6VKOKke16J9Y590iwqgsv1 i7VZ6Ol4ACn2S2vxfuiMBiPl48Drb4g9ClmbETAzH6j2mQ5YJbH0Zrzg6AfJOF9nMQ6lK4cc hXwU5nYahi5Ymidqmt1gFiUhNAKSSlHcirTZ3T/O2BhJ8MIqs6g0oaMQzYDPRImVkKf3fbSa ZX6vu8HafLvnzhfMfs= IronPort-HdrOrdr: A9a23:yQRjGKwRC7YfRM7jwuZ8KrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-Talos-CUID: =?us-ascii?q?9a23=3A5bgZPGgsA4LT8IbFmyjj+KU6sDJuW234xl3BG2u?= =?us-ascii?q?EJU1EE4a8GRy55qJ7up87?= X-Talos-MUID: 9a23:rZmwpgiuLKKZjuyoCNqlbsMpNeV6+YSSIhg0ra4buPCACAJIJxSfpWHi X-IronPort-AV: E=Sophos;i="5.99,266,1677560400"; d="scan'208";a="111128015" Date: Thu, 11 May 2023 14:30:23 +0100 From: "Anthony PERARD" To: Corvin =?iso-8859-1?Q?K=F6hne?= CC: , Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall Subject: Re: [PATCH v5 1/3] OvmfPkg/Xen: export search of RSDP into a library function Message-ID: <7f1ffbdb-89d1-4e18-a220-28f61c282f8f@perard> References: <20230511120239.695237-1-corvink@FreeBSD.org> MIME-Version: 1.0 In-Reply-To: <20230511120239.695237-1-corvink@FreeBSD.org> Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, May 11, 2023 at 02:02:37PM +0200, Corvin Köhne wrote: > diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > new file mode 100644 > index 000000000000..ce52ad31cf25 > --- /dev/null > +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > @@ -0,0 +1,62 @@ > +/** @file > + Copyright (c) 2023, Corvin Köhne As this new file move codes from OvmfPkg/XenAcpiPlatformDxe/Xen.c, shouldn't you also copy the "Copyright" lines from that file as well? Beside that, patch looks fine: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD