From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 26 Apr 2019 12:37:57 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id CAE15D4D83;
	Fri, 26 Apr 2019 19:37:56 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B5C7E5DAAF;
	Fri, 26 Apr 2019 19:37:53 +0000 (UTC)
Subject: Re: [PATCH V3 0/8] make mExitBootServicesEvent static
To: Zhichao Gao <zhichao.gao@intel.com>, devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
 Ray Ni <ray.ni@intel.com>, Star Zeng <star.zeng@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <liming.gao@intel.com>, Dandan Bi <dandan.bi@intel.com>
References: <20190426010404.20624-1-zhichao.gao@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7f415a51-2e5f-bd10-4ec3-d42aea513965@redhat.com>
Date: Fri, 26 Apr 2019 21:37:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190426010404.20624-1-zhichao.gao@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 26 Apr 2019 19:37:56 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/26/19 03:03, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
> 
> V1:
> The DebugLib instances of DebugPortProtocol, ConOut and StdErr
> use a global variable "mExitBootServicesEvent" which is in
> conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.
> That would cause a build error through GCC5. So change the
> name to the "mDebugLibExitBootServicesEvent".
> 
> V2:
> Abandon v1.
> Add a 'static' descriptor to the global variables that only
> used in a single file to minimize the name collisions.
> This is only for the variable named 'mExitBootServicesEvent'.
> 
> V3:
> Update the commit message and some copyright date.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> 
> Zhichao Gao (8):
>   MdePkg/UefiDebugLibConOut: make global variable static
>   MdePkg/UefiDebugLibDebugPortProtocol: make global variable static
>   MdePkg/UefiDebugLibStdErr: make global variable static
>   IntelFrameworkModulePkg: make global variable static
>   MdeModulePkg/FirmwarePerformanceDxe: make global variable static
>   IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static
>   IntelFrameworkModulePkg: make global variable static
>   MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static
> 
>  .../SmmRuntimeDxeSupport.c                                    | 4 ++--
>  .../DatahubStatusCodeHandlerDxe/DatahubStatusCodeHandlerDxe.c | 4 ++--
>  IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 ++--
>  .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c  | 4 ++--
>  .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c                  | 4 ++--
>  MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c       | 2 +-
>  .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c       | 2 +-
>  MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c       | 2 +-
>  8 files changed, 13 insertions(+), 13 deletions(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>