public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Marvin Häuser" <Marvin.Haeuser@outlook.com>,
	"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Cc: "jordan.l.justen@intel.com" <jordan.l.justen@intel.com>
Subject: Re: [PATCH] OvmfPkg/ResetVector: Remove the unused ASM ResetVector.
Date: Fri, 4 Nov 2016 00:46:18 +0100	[thread overview]
Message-ID: <7f435960-702c-d608-310a-5bb8bb6cbe1a@redhat.com> (raw)
In-Reply-To: <AM5PR0601MB2579959445FF575D6D1DFF6080A30@AM5PR0601MB2579.eurprd06.prod.outlook.com>

On 11/03/16 22:40, Marvin Häuser wrote:
> Remove the ResetVector.asm file as it is no longer referenced since
> the switch to ResetVector.nasmb.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
>  OvmfPkg/ResetVector/ResetVectorCode.asm | 53 --------------------
>  1 file changed, 53 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Jordan, do you think you could commit this patch? It's 00:46 here. :/

Thanks
Laszlo

> diff --git a/OvmfPkg/ResetVector/ResetVectorCode.asm b/OvmfPkg/ResetVector/ResetVectorCode.asm
> deleted file mode 100644
> index 052c821f212c..000000000000
> --- a/OvmfPkg/ResetVector/ResetVectorCode.asm
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -;------------------------------------------------------------------------------
> -; @file
> -; This file includes all other code files to assemble the reset vector code
> -;
> -; Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.<BR>
> -; This program and the accompanying materials
> -; are licensed and made available under the terms and conditions of the BSD License
> -; which accompanies this distribution.  The full text of the license may be found at
> -; http://opensource.org/licenses/bsd-license.php
> -;
> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -;
> -;------------------------------------------------------------------------------
> -
> -%ifdef ARCH_IA32
> -  %ifdef ARCH_X64
> -    %error "Only one of ARCH_IA32 or ARCH_X64 can be defined."
> -  %endif
> -%elifdef ARCH_X64
> -%else
> -  %error "Either ARCH_IA32 or ARCH_X64 must be defined."
> -%endif
> -
> -%include "CommonMacros.inc"
> -
> -%include "PostCodes.inc"
> -
> -%ifdef DEBUG_NONE
> -  %include "DebugDisabled.asm"
> -%elifdef DEBUG_PORT80
> -  %include "Port80Debug.asm"
> -%elifdef DEBUG_SERIAL
> -  %include "SerialDebug.asm"
> -%else
> -  %error "No debug type was specified."
> -%endif
> -
> -%include "Ia32/SearchForBfvBase.asm"
> -%include "Ia32/SearchForSecEntry.asm"
> -
> -%ifdef ARCH_X64
> -%include "Ia32/Flat32ToFlat64.asm"
> -%include "Ia32/PageTables64.asm"
> -%endif
> -
> -%include "Ia16/Real16ToFlat32.asm"
> -%include "Ia16/Init16.asm"
> -
> -%include "Main.asm"
> -
> -%include "Ia16/ResetVectorVtf0.asm"
> -
> 



  reply	other threads:[~2016-11-03 23:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 21:40 [PATCH] OvmfPkg/ResetVector: Remove the unused ASM ResetVector Marvin Häuser
2016-11-03 23:46 ` Laszlo Ersek [this message]
2016-11-03 23:53   ` Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f435960-702c-d608-310a-5bb8bb6cbe1a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox