From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 376F081CF0 for ; Thu, 3 Nov 2016 16:46:20 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C001F7F6D0; Thu, 3 Nov 2016 23:46:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.phx2.redhat.com [10.3.116.178]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3NkJwh019369; Thu, 3 Nov 2016 19:46:20 -0400 To: =?UTF-8?Q?Marvin_H=c3=a4user?= , "edk2-devel@lists.01.org" References: Cc: "jordan.l.justen@intel.com" From: Laszlo Ersek Message-ID: <7f435960-702c-d608-310a-5bb8bb6cbe1a@redhat.com> Date: Fri, 4 Nov 2016 00:46:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 03 Nov 2016 23:46:21 +0000 (UTC) Subject: Re: [PATCH] OvmfPkg/ResetVector: Remove the unused ASM ResetVector. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 23:46:20 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit On 11/03/16 22:40, Marvin Häuser wrote: > Remove the ResetVector.asm file as it is no longer referenced since > the switch to ResetVector.nasmb. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marvin Haeuser > --- > OvmfPkg/ResetVector/ResetVectorCode.asm | 53 -------------------- > 1 file changed, 53 deletions(-) Reviewed-by: Laszlo Ersek Jordan, do you think you could commit this patch? It's 00:46 here. :/ Thanks Laszlo > diff --git a/OvmfPkg/ResetVector/ResetVectorCode.asm b/OvmfPkg/ResetVector/ResetVectorCode.asm > deleted file mode 100644 > index 052c821f212c..000000000000 > --- a/OvmfPkg/ResetVector/ResetVectorCode.asm > +++ /dev/null > @@ -1,53 +0,0 @@ > -;------------------------------------------------------------------------------ > -; @file > -; This file includes all other code files to assemble the reset vector code > -; > -; Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.
> -; This program and the accompanying materials > -; are licensed and made available under the terms and conditions of the BSD License > -; which accompanies this distribution. The full text of the license may be found at > -; http://opensource.org/licenses/bsd-license.php > -; > -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -; > -;------------------------------------------------------------------------------ > - > -%ifdef ARCH_IA32 > - %ifdef ARCH_X64 > - %error "Only one of ARCH_IA32 or ARCH_X64 can be defined." > - %endif > -%elifdef ARCH_X64 > -%else > - %error "Either ARCH_IA32 or ARCH_X64 must be defined." > -%endif > - > -%include "CommonMacros.inc" > - > -%include "PostCodes.inc" > - > -%ifdef DEBUG_NONE > - %include "DebugDisabled.asm" > -%elifdef DEBUG_PORT80 > - %include "Port80Debug.asm" > -%elifdef DEBUG_SERIAL > - %include "SerialDebug.asm" > -%else > - %error "No debug type was specified." > -%endif > - > -%include "Ia32/SearchForBfvBase.asm" > -%include "Ia32/SearchForSecEntry.asm" > - > -%ifdef ARCH_X64 > -%include "Ia32/Flat32ToFlat64.asm" > -%include "Ia32/PageTables64.asm" > -%endif > - > -%include "Ia16/Real16ToFlat32.asm" > -%include "Ia16/Init16.asm" > - > -%include "Main.asm" > - > -%include "Ia16/ResetVectorVtf0.asm" > - >