From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.groups.io with SMTP id smtpd.web12.51202.1584966698055345982 for ; Mon, 23 Mar 2020 05:31:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P+rTVWqH; spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584966697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wP6Q8mp/aswYN2zosYyShucYTgm8N3E9h4n+BJot01A=; b=P+rTVWqHM4GMFwCCV1hkfd8g5/YfP976YTzEEk1lTw8utGzDHw++O8Y5fDYh60rS57KKUI vYd+rXFG7Qq5m+4uUV/tCVf2GthHi49rJkKdBAI62tBAy09jlfoaNTwcIAm7u9t7VnYzEs 4/1rSVVWWAFvJ0+siLc+M/XTPMvGzT4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-Ksj4teQjPUKDiLZCVu32wg-1; Mon, 23 Mar 2020 08:31:34 -0400 X-MC-Unique: Ksj4teQjPUKDiLZCVu32wg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76CCA800D5A; Mon, 23 Mar 2020 12:31:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B81E9B928; Mon, 23 Mar 2020 12:31:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms To: devel@edk2.groups.io, samer@elhajmahmoud.com Cc: Dandan Bi , Liming Gao , Hao A Wu , Leif Lindholm , Ard Biesheuvel References: <20200322160816.18426-1-samer@elhajmahmoud.com> From: "Laszlo Ersek" Message-ID: <7f587b1f-c02d-eafc-581f-d3de10a6ee7f@redhat.com> Date: Mon, 23 Mar 2020 13:31:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200322160816.18426-1-samer@elhajmahmoud.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote: > Set the default value of PcdAcpiExposedTableVersions for Aarch64 > platforms to 0x20. Previously, the default was set to 0x3E for all > platforms. The new value removes ACPI 1.0b compatability, which forces > the use of XSDT 64-bit pointer, as required by Arm SBBR specification. > This also resolves an error reported by acpiview command, as seen on > the RPi (see https://github.com/pftf/RPi4/issues/25). > > Cc: Dandan Bi > Cc: Liming Gao > Cc: Hao A Wu > Cc: Leif Lindholm > Cc: Ard Biesheuvel > > Signed-off-by: Samer El-Haj-Mahmoud > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 91a3c608231c..027f444903ef 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt Console Output Row of Text Setup > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT32|0x0001004c > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## UART clock frequency is for the baud rate configuration. > # @Prompt Serial Port Clock Rate. > Please consider appending another patch to this series: once the new DEC default is in place, the same PCD setting is no longer necessary in, and should arguably be removed from, "ArmVirtPkg/ArmVirtQemu.dsc": # ACPI predates the AARCH64 architecture by 5 versions, so # we only target OSes that support ACPI v5.0 or later gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 Basically: "git revert e0692789058e". Thanks! Laszlo