* [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms @ 2020-03-22 16:08 samer 2020-03-23 12:31 ` [edk2-devel] " Laszlo Ersek 2020-03-27 1:17 ` Dandan Bi 0 siblings, 2 replies; 8+ messages in thread From: samer @ 2020-03-22 16:08 UTC (permalink / raw) To: devel; +Cc: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm, Ard Biesheuvel Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to 0x20. Previously, the default was set to 0x3E for all platforms. The new value removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit pointer, as required by Arm SBBR specification. This also resolves an error reported by acpiview command, as seen on the RPi (see https://github.com/pftf/RPi4/issues/25). Cc: Dandan Bi <dandan.bi@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> --- MdeModulePkg/MdeModulePkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] # @Prompt Console Output Row of Text Setup gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT32|0x0001004c + [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## UART clock frequency is for the baud rate configuration. # @Prompt Serial Port Clock Rate. -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-22 16:08 [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms samer @ 2020-03-23 12:31 ` Laszlo Ersek 2020-03-23 12:53 ` Samer El-Haj-Mahmoud 2020-03-27 1:17 ` Dandan Bi 1 sibling, 1 reply; 8+ messages in thread From: Laszlo Ersek @ 2020-03-23 12:31 UTC (permalink / raw) To: devel, samer Cc: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm, Ard Biesheuvel On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote: > Set the default value of PcdAcpiExposedTableVersions for Aarch64 > platforms to 0x20. Previously, the default was set to 0x3E for all > platforms. The new value removes ACPI 1.0b compatability, which forces > the use of XSDT 64-bit pointer, as required by Arm SBBR specification. > This also resolves an error reported by acpiview command, as seen on > the RPi (see https://github.com/pftf/RPi4/issues/25). > > Cc: Dandan Bi <dandan.bi@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 91a3c608231c..027f444903ef 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt Console Output Row of Text Setup > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT32|0x0001004c > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## UART clock frequency is for the baud rate configuration. > # @Prompt Serial Port Clock Rate. > Please consider appending another patch to this series: once the new DEC default is in place, the same PCD setting is no longer necessary in, and should arguably be removed from, "ArmVirtPkg/ArmVirtQemu.dsc": # ACPI predates the AARCH64 architecture by 5 versions, so # we only target OSes that support ACPI v5.0 or later gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 Basically: "git revert e0692789058e". Thanks! Laszlo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-23 12:31 ` [edk2-devel] " Laszlo Ersek @ 2020-03-23 12:53 ` Samer El-Haj-Mahmoud 2020-03-24 23:03 ` Laszlo Ersek 0 siblings, 1 reply; 8+ messages in thread From: Samer El-Haj-Mahmoud @ 2020-03-23 12:53 UTC (permalink / raw) To: devel@edk2.groups.io, lersek@redhat.com, samer@elhajmahmoud.com Cc: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm, Ard Biesheuvel, Samer El-Haj-Mahmoud Thanks Laszlo I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20? Namely: edk2/ArmVirtPkg/ArmVirtQemu.dsc edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc edk2-platforms/Platform/Hisilicon/D06/D06.dsc edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek via Groups.Io Sent: Monday, March 23, 2020 8:31 AM To: devel@edk2.groups.io; samer@elhajmahmoud.com Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote: > Set the default value of PcdAcpiExposedTableVersions for Aarch64 > platforms to 0x20. Previously, the default was set to 0x3E for all > platforms. The new value removes ACPI 1.0b compatability, which forces > the use of XSDT 64-bit pointer, as required by Arm SBBR specification. > This also resolves an error reported by acpiview command, as seen on > the RPi (see https://github.com/pftf/RPi4/issues/25). > > Cc: Dandan Bi <dandan.bi@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt Console Output Row of Text Setup > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + > +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT3 > +2|0x0001004c > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## UART clock frequency is for the baud rate configuration. > # @Prompt Serial Port Clock Rate. > Please consider appending another patch to this series: once the new DEC default is in place, the same PCD setting is no longer necessary in, and should arguably be removed from, "ArmVirtPkg/ArmVirtQemu.dsc": # ACPI predates the AARCH64 architecture by 5 versions, so # we only target OSes that support ACPI v5.0 or later gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 Basically: "git revert e0692789058e". Thanks! Laszlo IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-23 12:53 ` Samer El-Haj-Mahmoud @ 2020-03-24 23:03 ` Laszlo Ersek 2020-03-25 2:03 ` Samer El-Haj-Mahmoud 0 siblings, 1 reply; 8+ messages in thread From: Laszlo Ersek @ 2020-03-24 23:03 UTC (permalink / raw) To: Samer El-Haj-Mahmoud, devel@edk2.groups.io, samer@elhajmahmoud.com Cc: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm, Ard Biesheuvel On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > Thanks Laszlo > > I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20? > > Namely: > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc > edk2-platforms/Platform/Hisilicon/D06/D06.dsc > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc If you can order the edk2-platforms changes safely after the edk2 DEC file change, then yes. Otherwise, I can't say. AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the ordering looks risky. But I generally don't follow edk2-platforms (which is also why I didn't grep its DSC files for the PCD in question), so I really don't know how such ordering questions have been dealt with in the past. Thanks Laszlo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-24 23:03 ` Laszlo Ersek @ 2020-03-25 2:03 ` Samer El-Haj-Mahmoud 2020-03-25 9:15 ` Ard Biesheuvel 0 siblings, 1 reply; 8+ messages in thread From: Samer El-Haj-Mahmoud @ 2020-03-25 2:03 UTC (permalink / raw) To: Laszlo Ersek, devel@edk2.groups.io, samer@elhajmahmoud.com Cc: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm, Ard Biesheuvel Thanks Laszlo, I will wait for the maintainers to accept the patch, then submit an amended version for ArmVirtQemu. -----Original Message----- From: Laszlo Ersek <lersek@redhat.com> Sent: Tuesday, March 24, 2020 7:03 PM To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io; samer@elhajmahmoud.com Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > Thanks Laszlo > > I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20? > > Namely: > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc > edk2-platforms/Platform/Hisilicon/D06/D06.dsc > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board > .dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc If you can order the edk2-platforms changes safely after the edk2 DEC file change, then yes. Otherwise, I can't say. AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the ordering looks risky. But I generally don't follow edk2-platforms (which is also why I didn't grep its DSC files for the PCD in question), so I really don't know how such ordering questions have been dealt with in the past. Thanks Laszlo IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-25 2:03 ` Samer El-Haj-Mahmoud @ 2020-03-25 9:15 ` Ard Biesheuvel 2020-03-26 21:12 ` Samer El-Haj-Mahmoud 0 siblings, 1 reply; 8+ messages in thread From: Ard Biesheuvel @ 2020-03-25 9:15 UTC (permalink / raw) To: Samer El-Haj-Mahmoud Cc: Laszlo Ersek, devel@edk2.groups.io, samer@elhajmahmoud.com, Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm On Wed, 25 Mar 2020 at 03:04, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> wrote: > > Thanks Laszlo, > > I will wait for the maintainers to accept the patch, then submit an amended version for ArmVirtQemu. > For this patch Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> For any patch that removes this PCD override from AArch64 platforms in edk2 or edk2-platforms: Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Tuesday, March 24, 2020 7:03 PM > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io; samer@elhajmahmoud.com > Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org> > Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms > > On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > > Thanks Laszlo > > > > I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20? > > > > Namely: > > > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc > > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc > > edk2-platforms/Platform/Hisilicon/D06/D06.dsc > > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc > > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board > > .dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc > > If you can order the edk2-platforms changes safely after the edk2 DEC file change, then yes. > > Otherwise, I can't say. > > AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the ordering looks risky. But I generally don't follow edk2-platforms (which is also why I didn't grep its DSC files for the PCD in question), so I really don't know how such ordering questions have been dealt with in the past. > > Thanks > Laszlo > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-25 9:15 ` Ard Biesheuvel @ 2020-03-26 21:12 ` Samer El-Haj-Mahmoud 0 siblings, 0 replies; 8+ messages in thread From: Samer El-Haj-Mahmoud @ 2020-03-26 21:12 UTC (permalink / raw) To: Dandan Bi, Liming Gao, Hao A Wu, Leif Lindholm Cc: Laszlo Ersek, Ard Biesheuvel, devel@edk2.groups.io, samer@elhajmahmoud.com Thanks Ard and Laszlo. Leif, Dandan, Liming, Hao, any objection in merging this patch to edk2? > -----Original Message----- > From: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Sent: Wednesday, March 25, 2020 5:16 AM > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> > Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; > samer@elhajmahmoud.com; Dandan Bi <dandan.bi@intel.com>; Liming Gao > <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm > <leif@nuviainc.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: > PcdAcpiExposedTableVersions default for Arm64 platforms > > On Wed, 25 Mar 2020 at 03:04, Samer El-Haj-Mahmoud <Samer.El-Haj- > Mahmoud@arm.com> wrote: > > > > Thanks Laszlo, > > > > I will wait for the maintainers to accept the patch, then submit an amended > version for ArmVirtQemu. > > > > For this patch > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > For any patch that removes this PCD override from AArch64 platforms in > edk2 or edk2-platforms: > > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > -----Original Message----- > > From: Laszlo Ersek <lersek@redhat.com> > > Sent: Tuesday, March 24, 2020 7:03 PM > > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; > > devel@edk2.groups.io; samer@elhajmahmoud.com > > Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao > > <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm > > <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: > > PcdAcpiExposedTableVersions default for Arm64 platforms > > > > On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > > > Thanks Laszlo > > > > > > I agree. But shouldn't we remove the PCD settings from all Arm64 > platforms that have this override value of 0x20? > > > > > > Namely: > > > > > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > > > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc > > > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > > > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc > > > edk2-platforms/Platform/Hisilicon/D06/D06.dsc > > > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc > > > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Boa > > > rd .dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc > > > > If you can order the edk2-platforms changes safely after the edk2 DEC file > change, then yes. > > > > Otherwise, I can't say. > > > > AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the > ordering looks risky. But I generally don't follow edk2-platforms (which is also > why I didn't grep its DSC files for the PCD in question), so I really don't know > how such ordering questions have been dealt with in the past. > > > > Thanks > > Laszlo > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms 2020-03-22 16:08 [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms samer 2020-03-23 12:31 ` [edk2-devel] " Laszlo Ersek @ 2020-03-27 1:17 ` Dandan Bi 1 sibling, 0 replies; 8+ messages in thread From: Dandan Bi @ 2020-03-27 1:17 UTC (permalink / raw) To: Samer El-Haj-Mahmoud, devel@edk2.groups.io Cc: Gao, Liming, Wu, Hao A, Leif Lindholm, Ard Biesheuvel Reviewed-by: Dandan Bi <dandan.bi@intel.com> Thanks, Dandan > -----Original Message----- > From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com] > Sent: Monday, March 23, 2020 12:08 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; > Wu, Hao A <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard > Biesheuvel <ard.biesheuvel@linaro.org> > Subject: [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions > default for Arm64 platforms > > Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms > to 0x20. Previously, the default was set to 0x3E for all platforms. The new > value removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit > pointer, as required by Arm SBBR specification. > This also resolves an error reported by acpiview command, as seen on the > RPi (see https://github.com/pftf/RPi4/issues/25). > > Cc: Dandan Bi <dandan.bi@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > # @Prompt Console Output Row of Text Setup > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40 > 00000e > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + > +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20| > UINT32| > +0x0001004c > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## UART clock frequency is for the baud rate configuration. > # @Prompt Serial Port Clock Rate. > -- > 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-27 1:17 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-22 16:08 [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms samer 2020-03-23 12:31 ` [edk2-devel] " Laszlo Ersek 2020-03-23 12:53 ` Samer El-Haj-Mahmoud 2020-03-24 23:03 ` Laszlo Ersek 2020-03-25 2:03 ` Samer El-Haj-Mahmoud 2020-03-25 9:15 ` Ard Biesheuvel 2020-03-26 21:12 ` Samer El-Haj-Mahmoud 2020-03-27 1:17 ` Dandan Bi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox