From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::642; helo=mail-pl1-x642.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A0854201B0416 for ; Tue, 12 Feb 2019 04:18:11 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id w4so1233197plz.1 for ; Tue, 12 Feb 2019 04:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XbhW55iXF7tr+jU/uUxDplSZs+7N5Djq8xynBfnDxTc=; b=QmOcjn9PPCheii7bSHcK8cxLj3QmfB18VGsgLyczlx8JN09CEVs3vrmisHw3ankNFm SGjk7zzNSk/lg0Uh3ERCT8fgMmqE2UAwDEPTFh0Kzu6RwSRaYF8A4SwIbwfWDmSu0soB soVckBfkIY7Uy2TPFNPpIRf8GE5Lw1WRNNOSGSKrsdl5PaSAZQsyr2v1wQ76s+WNWUL3 cryaCIgHuXSslokU7zI+toOcfB0FKz/9B9x3hJAO637bINFomwPpPHDxI1hzMH8esoRd T210eOYmtH/J1KOCtRy5eJgy1/rH38yg75rlq0NwRNXpm6+9/KEIeSin/QijNWHfYs9o 5Qag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XbhW55iXF7tr+jU/uUxDplSZs+7N5Djq8xynBfnDxTc=; b=iFkupDO6gy2iY8/e953lfyMcGft3zBXxHbbrOfQ2WCCNjjogiWQzR1qKIYtYa7tK25 WXxXYvz6pcKTD0pdZFdhFSpl54aOcP6wSvh1Pr1/Ryhya1B2A8Uu5QqYivbBbvEaWbgv MZOU97kPYDkVd187ude8FI5lFOR842V+dwQ1zwsY7OgwbKHV/jdFPs6GCfY7KXukC5mV OuLD7lCez8U5PdckMmWjKBhwaQsPySSKPdnzX6EE7K1aov95YtjzzovYnPE8YOaGsXIl ZQ+Iikyux/wDMpSY/lysHQvCq43PCZpA8oL0nY5duOKKf+S+mI+tHTjo2RCiLug1z0nN L2HA== X-Gm-Message-State: AHQUAuZ0lwS8hxKyk5E7BLnPGeahD/egKieRHBZjxelzWuGFpzlKGYFc EXzx37PjPb7IfO53J9IYS7yz+A== X-Google-Smtp-Source: AHgI3IbKXeZtTYamEUny8MqSc34D2ynnhb6YQ0/hTAO8eCDDATTlk2la0bA3VdqL95m3kB0zODkF8Q== X-Received: by 2002:a17:902:8341:: with SMTP id z1mr3794476pln.150.1549973891265; Tue, 12 Feb 2019 04:18:11 -0800 (PST) Received: from [10.15.0.66] ([64.64.108.250]) by smtp.gmail.com with ESMTPSA id q127sm17060732pgq.39.2019.02.12.04.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 04:18:10 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-7-ming.huang@linaro.org> <20190211144854.6kw2ryyauzpcz6po@bivouac.eciton.net> From: Ming Huang Message-ID: <7f7d0dba-f258-5829-9a8f-0ce5199d7849@linaro.org> Date: Tue, 12 Feb 2019 20:17:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190211144854.6kw2ryyauzpcz6po@bivouac.eciton.net> Subject: Re: [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 12:18:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/11/2019 10:48 PM, Leif Lindholm wrote: > *bangs head on desk* > > That question I just asked as a reply to > ("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot") > was meant to be a comment on this patch. > > So - was this change one that was meant to happen together with > edk2-platforms "Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot"? Yes, it is better to happen together with that patch. > > What is the user visible behaviour that this change addresses? Numa info of kernel boot is different: Use old MemoryInit.efi: [ 0.000000] ACPI: SRAT: Node 1 PXM 0 [mem 0x2080000000-0x23ffffffff] [ 0.000000] ACPI: SRAT: Node 1 PXM 0 [mem 0x00000000-0x7fffffff] [ 0.000000] ACPI: SRAT: Node 3 PXM 2 [mem 0xa2000000000-0xa23ffffffff] Use new MemoryInit.efi: [ 0.000000] ACPI: SRAT: Node 1 PXM 1 [mem 0x2080000000-0x23ffffffff] [ 0.000000] ACPI: SRAT: Node 1 PXM 1 [mem 0x00000000-0x7fffffff] [ 0.000000] ACPI: SRAT: Node 3 PXM 3 [mem 0xa2000000000-0xa23ffffffff]o Thanks. > > / > Leif > > On Fri, Feb 01, 2019 at 10:25:06PM +0800, Ming Huang wrote: >> Numa informations are acquired from HOB that build from memory >> initialization module. Correct numa informations to match booting >> from TA(Totem A or super cpu cluster A). >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi | Bin 297696 -> 358656 bytes >> 1 file changed, 0 insertions(+), 0 deletions(-) >> >> diff --git a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi >> index 5fba353..fea1475 100644 >> Binary files a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi differ >> -- >> 2.9.5 >>