From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (NAM04-BN3-obe.outbound.protection.outlook.com [40.107.68.73]) by mx.groups.io with SMTP id smtpd.web09.1681.1576182482330313027 for ; Thu, 12 Dec 2019 12:28:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=fhYQ/b0l; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.68.73, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N+1DlW4QVTSAgcrlMF5lf5TsARAJTHZx3FzrKtQf/FLyWdnPaqOq+irEBAocuealg45dFl4+m1a7oBSXG3r3gQPdwzMCU3Yjzk6ueWK8L04IhsEpO8xQ+6nCtyAlJNrMqJFezHAwCr19ywo8MfYJPdeIc+GnBJV9zSNlRJYxwX4NaRRQqnVDD43QZq7utTQltqIQ5HbKENGqrrba4LAcKmT4Bm+3/yIxjl9G3zlKTFlTZBUCi2JNrXJpHuiiNjKQjGEiXT1PhZfeUyYXQ84r1GB4cdFVOVk9XOw7AJSFakoupdutqVvmQ+VtWkTDpmfNGw5mjzoPgiFHKXdhz7PgTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrYrqhO5PyLF4Tl8TXbBHs+u50z3Qd65X7EM03+amDA=; b=j13nAMrtjdlsLD0MWMDrbrOQsm7fRAdwZ4h7SeBEcq8QNSi0hLU/8AgQUebnYeN+3hkO+5aYXVb1dTaAmB5tLulHqdDPAXDZJWO7ipRXkGpMK1e7FOPjSkfl8Z8DIJZIHy6BA7zpW1em+p/w9VFiTKdYfDhnaPJUxTG8hvWkCVDOnf7R+qxeTP2i32+QftzU20UgxySFBANNdLAj2Ckikx3GAq4du4tcpXthBkuj/w3qjb7SVF1LPtyGTiwOl1ORzMEnKTKTg7T/M9pBOENPNN/gf3ITuO937kFI28u6hOa0B5oSWecsgqpofNaRA11aJTCp8PzkEobQIB0ps80Wpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrYrqhO5PyLF4Tl8TXbBHs+u50z3Qd65X7EM03+amDA=; b=fhYQ/b0lIlaPzuJMtUQC0Zxv6f+gfeavCx+dGv2vT4LZZVSNrhDB7cLBYUlm4st1ixreMvdbE9giWla+opfp2pSCAKrmRcIndRXOdXWkVPSye1OtDqy8w2QCKRA6v/G1FzyNisuHq0vynfMsAbFL7vWtFC+hp/V0t/4VEG/7y+I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from DM6PR12MB3163.namprd12.prod.outlook.com (20.179.71.154) by DM6PR12MB3945.namprd12.prod.outlook.com (10.255.172.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Thu, 12 Dec 2019 20:28:00 +0000 Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::c16f:b437:4266:dbc1]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::c16f:b437:4266:dbc1%4]) with mapi id 15.20.2516.020; Thu, 12 Dec 2019 20:28:00 +0000 Subject: Re: [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events To: "Ni, Ray" , "devel@edk2.groups.io" Cc: "Justen, Jordan L" , Laszlo Ersek , Ard Biesheuvel , "Kinney, Michael D" , "Gao, Liming" , "Dong, Eric" , Brijesh Singh References: <734D49CCEBEEF84792F5B80ED585239D5C399A2E@SHSMSX104.ccr.corp.intel.com> From: "Lendacky, Thomas" Message-ID: <7f7e1915-72af-9945-779c-38a1e4c8151a@amd.com> Date: Thu, 12 Dec 2019 14:27:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C399A2E@SHSMSX104.ccr.corp.intel.com> X-ClientProxiedBy: SN4PR0401CA0022.namprd04.prod.outlook.com (2603:10b6:803:21::32) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 07c2e6fb-d55c-47dc-7438-08d77f41c7f3 X-MS-TrafficTypeDiagnostic: DM6PR12MB3945:|DM6PR12MB3945: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:597; X-Forefront-PRVS: 0249EFCB0B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(39840400004)(136003)(346002)(366004)(376002)(396003)(199004)(189003)(53546011)(6506007)(558084003)(2616005)(31696002)(81156014)(6512007)(186003)(4326008)(81166006)(26005)(66556008)(31686004)(8676002)(66476007)(36756003)(2906002)(6486002)(8936002)(52116002)(66946007)(478600001)(316002)(54906003)(86362001)(5660300002)(110136005);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB3945;H:DM6PR12MB3163.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FB+zrJyGqyfLiggREaSrCpj/kx6FhHJBaPD+XDCaR/4yEn2BJP/tMgIbg8yi5BvdBb5Au9N2oDZAfrKTPknQRM6tibdh5szsORBc+73yEvAM64UrCkRsyARWzf/lx9St5Lcnfhx0EezTuyuhtE+ygUSB+jV21GToWBwoYEl3V540Xyik+l7ZuJbkd7eFeHvEW3LctHnAfdxFqZnydt/pskScY36xvnSCsIX5iwM74GHOY4OmGNiYJTUN8nVhDh0vIreGOS1nRTYzk56lbdJTQtC+JDzkj3mzwvbqMwZd0Zf3kLXDUisZVGOE+UNL9SV6YOf3a//xhUnRQrcNbEv1Pzp9LnKFaZw2j7KZYwaj48xYawGOXBdgKDd+XDI1mWy6w5poPeLWLWu72jFOOssP6DDygyyl/+IPEDHqriK4p05yR1tCNynjsaLWT7z55rHv X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07c2e6fb-d55c-47dc-7438-08d77f41c7f3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2019 20:28:00.2066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NkVO6iOGBOzqEonB4reTLEAEyhJuH703APGMkjCuEGO6cJvlclMDsTSDBaRjBgr26bvmo8Xog+PFF0V1dvFQfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3945 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/12/19 12:53 AM, Ni, Ray wrote: >> >> ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >> + cmp qword [rbp + 8], 29 > > Can you define a macro instead of using 29? Yes, I can do that. Thanks, Tom > >> + je VcDebugRegs ; For SEV-ES (#VC) Debug registers ignored > >