From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.87257.1597843175322237197 for ; Wed, 19 Aug 2020 06:19:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X+fJGT2c; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597843174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=76vc3atMfsPqGXBgU1NIMwZR8Kt9XWf0bR42o/s/Xog=; b=X+fJGT2cAPhBQ23EMor7rduyCdac0uHAeXcOt3t77rgDuR0aJDGi1pNzlDukv9L0rzksj9 owuZ4DZZZqIJ6euhxA31eqr1lbmRi5NBz/3WwJy4tuwcbS5SKESbgLN5mjvdhdZzgh+d2X ALk3aysiqD2CXuWB248EeOAzMtUX2YU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-NkCHV9X4PX6Wt38m4wIhgA-1; Wed, 19 Aug 2020 09:19:17 -0400 X-MC-Unique: NkCHV9X4PX6Wt38m4wIhgA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B160B100CA94; Wed, 19 Aug 2020 13:19:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-57.ams2.redhat.com [10.36.114.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id E842E19C4F; Wed, 19 Aug 2020 13:19:13 +0000 (UTC) Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008 To: Leif Lindholm , "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "liming.gao" , "announce@edk2.groups.io" , "afish@apple.com" , "Kinney, Michael D" References: <877468e5-d154-14fc-b23b-ffa8fd2c9103@redhat.com> <03b3deed-8506-94c3-d14a-eca9198b48a2@redhat.com> <20200819114853.GF17439@vanye> From: "Laszlo Ersek" Message-ID: <7fa9c99d-56d1-842e-3fd4-2d3fe649b588@redhat.com> Date: Wed, 19 Aug 2020 15:19:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200819114853.GF17439@vanye> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 08/19/20 13:48, Leif Lindholm wrote: > (Slightly trimmed recipient list due to different patch being discussed.) > > So, I can't make this call, because I'm the one who messed up. > > This patch does exactly what I had requested Abner to do some time > back (off-list, unfortunately), and I was *convinced* I gave it an R-b > as soon as it hit my inbox - until Abner nudged me about it yesterday. > > The patch in question is > https://edk2.groups.io/g/devel/topic/76021725 My understanding is: (1) there is an external project that consumes the FDT library in EmbeddedPkg, meaning the lib class header "EmbeddedPkg/Include/libfdt.h" and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf", (2) the lib class header pulls in "fdt.h" and "libfdt_env.h", (3) the external project is not edk2-platforms, (4) the external project wants -- for some strange reason -- edk2's "libfdt_env.h" to provide an strncmp() function (or function-like macro), with that particular stncmp() implementation not being needed in either edk2-platforms or edk2 itself, (5) the patch for adding said strncmp() was posted on Aug 6th (at least when viewed from my time zone), i.e., before the SFF, (6) it was reviewed 12 days later (within the SFF) If my understanding is correct, then I don't see how this patch could be considered a bugfix -- even as a feature addition, it seems hardly justified to me --, and there would have been ~8 days before the SFF to review it. I think we should postpone the patch until after the stable tag. Thanks Laszlo > On Wed, Aug 19, 2020 at 11:29:52 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: >> Hmm.. I had a one commit (which is not the feature) just reviewed by >> Leif but not pushing yet. Is that possible to push before the Hard >> Feature freeze and also be included in 202008 stable tag? I guess it >> gets the chance according to the article of SoftFeatureFreeze on >> Wiki page. >> >> Patch attached FYR >> >> Abner >> >>> -----Original Message----- >>> From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On >>> Behalf Of Laszlo Ersek >>> Sent: Wednesday, August 19, 2020 5:59 PM >>> To: Bret Barkelew ; devel@edk2.groups.io; >>> liming.gao ; announce@edk2.groups.io >>> Cc: Leif Lindholm ; afish@apple.com; Kinney, Michael D >>> ; Guptha, Soumya K >>> >>> Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze starts >>> now for edk2-stable202008 >>> >>> On 08/18/20 17:10, Bret Barkelew wrote: >>>> I agree with the process and withdraw my request, replacing it instead with >>> a disapproving head shake and deep sigh. >>> >>> We as a community definitely deserve your disapproval, as our review >>> response times have been abysmal. :( >>> >>>> I’ll go back to pushing on this after the tag. >>> >>> Thanks for your persistence! >>> Laszlo >>> >>> >>> >> > >