From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49D0B2097E274 for ; Thu, 2 Aug 2018 10:40:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E698C8197021; Thu, 2 Aug 2018 17:40:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-32.rdu2.redhat.com [10.10.123.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17E702166BA2; Thu, 2 Aug 2018 17:40:30 +0000 (UTC) To: "Gao, Liming" , edk2-devel-01 References: <20180726004415.13381-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C4BDF@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <7fcaa55c-abf5-25ff-2a08-6168ee10fd01@redhat.com> Date: Thu, 2 Aug 2018 19:40:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C4BDF@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 17:40:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 17:40:31 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 17:40:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/02/18 17:40, Gao, Liming wrote: > Laszlo: > I understand this patch set is to provide the way to append compile and link option for BaseTools source build. Yes. > If so, the extend flag name may be EXTRA_CCFLAGS I can rename EXTRA_OPTFLAGS to EXTRA_CCFLAGS, but in that case, internally we will have: BUILD_OPTFLAGS = -O2 $(EXTRA_CCFLAGS) in "header.makefile". In that case, I expect to receive a comment that we shouldn't append a generic "CCFLAGS" variable to a more specialized "OPTFLAGS" variable. Obviously, I can rename "BUILD_OPTFLAGS" to "BUILD_CCFLAGS" as well -- but, in that case, I expect to receive a comment that we already have "BUILD_CFLAGS". The variable (more precisely, "RPM macro") that the Fedora distribution will put into EXTRA_OPTFLAGS is also called %{optflags}. So I think EXTRA_OPTFLAGS is an appropriate name. If you still disagree, then can you please suggest a new name not just for EXTRA_OPTFLAGS (-->EXTRA_CCFLAGS), but also for BUILD_OPTFLAGS? Patch #3 explains why we need a separate BUILD_OPTFLAGS Makefile macro. > and EXTRA_LDFLAGS. Right, that's the currently proposed name. > And, the extend flags are appended in the tail. Correct. > Besides, Pccts is the internal tool to generate VfrCompiler syntax source file. It is not used in build process. I am not sure why they also require the additional CC and LD flags. It's a general policy thing; all native binaries should be built with the system-wide flags. Some of those flags will let the binaries detect some buffer overflows automatically, for example, which is helpful even if the utility is never installed / packaged, just used as a one-off build tool. Thanks! Laszlo > > Thanks > Liming >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Thursday, July 26, 2018 8:44 AM >> To: edk2-devel-01 >> Cc: Gao, Liming ; Zhu, Yonghong >> Subject: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller >> >> Repo: https://github.com/lersek/edk2.git >> Branch: extra_flags_rhbz1540244 >> >> In the Fedora distribution, we'd like to pass system-wide flags related >> to optimization and linking when the C and C++ language base tools are >> built. This series lets the outermost "make" command push the >> EXTRA_OPTFLAGS and EXTRA_LDFLAGS macros into the BaseTools build. >> >> Cc: Liming Gao >> Cc: Yonghong Zhu >> >> Thanks >> Laszlo >> >> Laszlo Ersek (6): >> BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too >> BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS >> BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS >> BaseTools/Pccts: clean up antlr and dlg makefiles >> BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller >> BaseTools/Source/C: take EXTRA_LDFLAGS from the caller >> >> BaseTools/Source/C/Makefiles/footer.makefile | 2 +- >> BaseTools/Source/C/Makefiles/header.makefile | 16 ++++++++--- >> BaseTools/Source/C/VfrCompile/GNUmakefile | 11 +++++--- >> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 22 ++++++++++----- >> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 28 +++++++++++++------- >> 5 files changed, 56 insertions(+), 23 deletions(-) >> >> -- >> 2.14.1.3.gb7cf6e02401b >