* [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
@ 2020-08-26 23:20 Samer El-Haj-Mahmoud
2020-08-26 23:23 ` Pete Batard
2020-08-27 7:56 ` Ard Biesheuvel
0 siblings, 2 replies; 4+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-08-26 23:20 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard, Andrei Warkentin
Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
extern module global, but did not remove the STATIC declaration, which
caused the build to break. Fix the build error by removing STATIC for
that module global variable.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
index ae4b2735820c..3eba98e5aa87 100644
--- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
+++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
@@ -87,7 +87,7 @@ DisplayBlt (
IN UINTN Delta OPTIONAL
);
-STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
+EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
DriverSupported,
DriverStart,
DriverStop,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
2020-08-26 23:20 [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Samer El-Haj-Mahmoud
@ 2020-08-26 23:23 ` Pete Batard
2020-08-27 5:27 ` Andrei Warkentin
2020-08-27 7:56 ` Ard Biesheuvel
1 sibling, 1 reply; 4+ messages in thread
From: Pete Batard @ 2020-08-26 23:23 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel
Cc: Leif Lindholm, Ard Biesheuvel, Andrei Warkentin
On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote:
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
> extern module global, but did not remove the STATIC declaration, which
> caused the build to break. Fix the build error by removing STATIC for
> that module global variable.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
> Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
> IN UINTN Delta OPTIONAL
> );
>
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> DriverSupported,
> DriverStart,
> DriverStop,
>
Reviewed-by: Pete Batard <pete@akeo.ie>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
2020-08-26 23:23 ` Pete Batard
@ 2020-08-27 5:27 ` Andrei Warkentin
0 siblings, 0 replies; 4+ messages in thread
From: Andrei Warkentin @ 2020-08-27 5:27 UTC (permalink / raw)
To: Pete Batard, Samer El-Haj-Mahmoud, devel@edk2.groups.io
Cc: Leif Lindholm, Ard Biesheuvel
[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>
________________________________
From: Pete Batard <pete@akeo.ie>
Sent: Wednesday, August 26, 2020 6:23 PM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Andrei Warkentin <awarkentin@vmware.com>
Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote:
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
> extern module global, but did not remove the STATIC declaration, which
> caused the build to break. Fix the build error by removing STATIC for
> that module global variable.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
> Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
> IN UINTN Delta OPTIONAL
> );
>
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> DriverSupported,
> DriverStart,
> DriverStop,
>
Reviewed-by: Pete Batard <pete@akeo.ie>
[-- Attachment #2: Type: text/html, Size: 3126 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
2020-08-26 23:20 [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Samer El-Haj-Mahmoud
2020-08-26 23:23 ` Pete Batard
@ 2020-08-27 7:56 ` Ard Biesheuvel
1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-08-27 7:56 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel; +Cc: Leif Lindholm, Pete Batard, Andrei Warkentin
On 8/27/20 1:20 AM, Samer El-Haj-Mahmoud wrote:
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
> extern module global, but did not remove the STATIC declaration, which
> caused the build to break. Fix the build error by removing STATIC for
> that module global variable.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Pushed as 0cb34c0de123..5955ac2f10af
Thanks all
> ---
> Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
> IN UINTN Delta OPTIONAL
> );
>
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> DriverSupported,
> DriverStart,
> DriverStop,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-27 7:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 23:20 [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Samer El-Haj-Mahmoud
2020-08-26 23:23 ` Pete Batard
2020-08-27 5:27 ` Andrei Warkentin
2020-08-27 7:56 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox