From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.7404.1598484218961567261 for ; Wed, 26 Aug 2020 16:23:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=zaHEV11l; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id x9so3510149wmi.2 for ; Wed, 26 Aug 2020 16:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4pl/EJnH95apGyIP2vIuQvbyLXVt8HJJbLoRJvhGnWk=; b=zaHEV11lc4jNkhXdWa9cTivllPwqk6dOZLFFb0B+slJOOCfUY70rh20chaAkP+NU42 2T/v5QM4uK6TGyWpJecLcvpKEk1GAKhYWd6oJU9ljRVqesypCpMqjLo9zxAX2cggGYVo 4BmbOAxaAXPKJPCv0GXHeBH4uwx+fmSYM66xu0ASCZgPKwPv9YTdOHFg96hwok/0cuvi ArjY/7zY0Z7JPucEaD4g0Sjr1fu+2m8XsmNTUGq6bzeYlw2iQtXD3my9+ewt5ATNnen5 kFQhVXVQ7gBvdNtiiX99ZgktubDKLcPgJH4VUPs3zWYpjoMbDpP/F8PUle96L94nij8r 4nxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4pl/EJnH95apGyIP2vIuQvbyLXVt8HJJbLoRJvhGnWk=; b=olWmc28pNJK4pWDWScHVBGRCLEs67vJE8q9GTFOajgyGehuYbOTgfapbhRG2+ecdVS 6E19b/T/m6NkWoKbk0c2zyzMFgN39txm6XHPNjJtv7Azzb+qE2zRn7MSvNG5D5KKt1Hu 94iZHfcNcTlc4+6BLLT3StWa7yEuxyFHtAR/fuDv291vhLGT7DbQAx77VujEheWiArgc +FNhR1aTaYR+a4W+e0Q231+MK4UqJ4FstbIMD57Y/Hxa0KYlyCeS8QYst/B8kCPmyJnM gFE2ktRtoHT3uMdvygkJTdvhiKK2OnK89sHDo0BWMIUaUXe/F6RC/s77LLF6xyCysJJb KD7g== X-Gm-Message-State: AOAM531QmNvfzLTqMY2+xt/0J6WYkBFXpTlXOlSBfIAbIACzvQjkuw1G 0ykm08Md2Zl4DwUfP6c9IkrmKw== X-Google-Smtp-Source: ABdhPJwoFc9Amlzkrqz5E1MV0NgUQwEuI2Ur5bnFB+p3vi84698P4DcTrwKAQsoAFv2x+INg+5KlGQ== X-Received: by 2002:a7b:c95a:: with SMTP id i26mr9567671wml.106.1598484217131; Wed, 26 Aug 2020 16:23:37 -0700 (PDT) Return-Path: Received: from [10.0.0.130] ([84.203.59.61]) by smtp.googlemail.com with ESMTPSA id v7sm16035634wma.1.2020.08.26.16.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2020 16:23:36 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Andrei Warkentin References: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: <7fcfa2f2-b6ad-21b1-894d-8bdb4a7642dd@akeo.ie> Date: Thu, 27 Aug 2020 00:23:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote: > Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding > extern module global, but did not remove the STATIC declaration, which > caused the build to break. Fix the build error by removing STATIC for > that module global variable. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Pete Batard > Cc: Andrei Warkentin > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > index ae4b2735820c..3eba98e5aa87 100644 > --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > @@ -87,7 +87,7 @@ DisplayBlt ( > IN UINTN Delta OPTIONAL > ); > > -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = { > +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = { > DriverSupported, > DriverStart, > DriverStop, > Reviewed-by: Pete Batard