public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pete Batard <pete@akeo.ie>, devel@edk2.groups.io
Cc: leif@nuviainc.com, awarkentin@vmware.com
Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI
Date: Wed, 6 May 2020 14:26:47 +0200	[thread overview]
Message-ID: <7fe273c7-f0f0-b60f-39a8-e4385271abb6@arm.com> (raw)
In-Reply-To: <20200506113748.8060-1-pete@akeo.ie>

On 5/6/20 1:37 PM, Pete Batard wrote:
...
> Therefore, since we do see a need for ACPI 6.x features, and
> effectively have a 6.3 table with PPTT, and also since we have
> tested that we are not seeing ill effects from doing so for the
> most common OSes we support, we bring all of the relevant ACPI
> tables to version 6.3.
> 
> This is mostly accomplished by simply altering the version of
> ACPI being references in the macros,

OK, so even the macros that resolve to the exact same code are renamed. 
I suppose this means a blanket rename of everything once ACPI 6.4 comes out?

> except for the new fields
> being initialized in the MADT table where we:
> * Use 1 for GICR Base Address in GICC_STRUCTURE_INIT because, even
>    as this field is not supposed to apply to any of our platforms,
>    this is what Microsoft used in the original Pi 3 hardcoded MADT
>    blobs and Windows 10 doesn't boot on the Pi 3 if set to 0.

Fair enough.

> * Use 2 for GIC version in GIC_DISTRIBUTOR_INIT, since the Pi 4 GIC
>    is v2 only.
> 

OK. But you are introducing new references to ACPI_6_0 macros here. If 
the point is to rename everything for cosmetic reasons, shouldn't you 
use 6.3 there as well?

  reply	other threads:[~2020-05-06 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 11:37 [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI Pete Batard
2020-05-06 12:26 ` Ard Biesheuvel [this message]
2020-05-06 12:45   ` Pete Batard
2020-05-06 12:50     ` Ard Biesheuvel
2020-05-06 12:56       ` Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fe273c7-f0f0-b60f-39a8-e4385271abb6@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox