From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.5073.1588768012782383830 for ; Wed, 06 May 2020 05:26:52 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D214C1FB; Wed, 6 May 2020 05:26:51 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 948DA3F71F; Wed, 6 May 2020 05:26:50 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI To: Pete Batard , devel@edk2.groups.io Cc: leif@nuviainc.com, awarkentin@vmware.com References: <20200506113748.8060-1-pete@akeo.ie> From: "Ard Biesheuvel" Message-ID: <7fe273c7-f0f0-b60f-39a8-e4385271abb6@arm.com> Date: Wed, 6 May 2020 14:26:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506113748.8060-1-pete@akeo.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/6/20 1:37 PM, Pete Batard wrote: ... > Therefore, since we do see a need for ACPI 6.x features, and > effectively have a 6.3 table with PPTT, and also since we have > tested that we are not seeing ill effects from doing so for the > most common OSes we support, we bring all of the relevant ACPI > tables to version 6.3. > > This is mostly accomplished by simply altering the version of > ACPI being references in the macros, OK, so even the macros that resolve to the exact same code are renamed. I suppose this means a blanket rename of everything once ACPI 6.4 comes out? > except for the new fields > being initialized in the MADT table where we: > * Use 1 for GICR Base Address in GICC_STRUCTURE_INIT because, even > as this field is not supposed to apply to any of our platforms, > this is what Microsoft used in the original Pi 3 hardcoded MADT > blobs and Windows 10 doesn't boot on the Pi 3 if set to 0. Fair enough. > * Use 2 for GIC version in GIC_DISTRIBUTOR_INIT, since the Pi 4 GIC > is v2 only. > OK. But you are introducing new references to ACPI_6_0 macros here. If the point is to rename everything for cosmetic reasons, shouldn't you use 6.3 there as well?