From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.1891.1587750529550168947 for ; Fri, 24 Apr 2020 10:48:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=A2+QoF2Q; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587750528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0COmkbmfpKUjm5Z1xKc/HCSYMTSkmiiDstjUqX//Zrw=; b=A2+QoF2QP6Z8sVb6vLFW9LJdF+aczCIVVDWCFrr44uS8ncpF0+UYLIbDTRADZFbiG1j5hF AUX0uqSqUsyKTH6JS63z96Ao8BKBlcrN0nCFsETZ+mur/L9w0BRSaCTJxKZdw8o20+u3Vr oGiVLNwGZrszpnDDOyj4UJrU3sLWkC0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-vvA2-zsAP4aWxojFq_W9fQ-1; Fri, 24 Apr 2020 13:48:47 -0400 X-MC-Unique: vvA2-zsAP4aWxojFq_W9fQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B59BC90A440; Fri, 24 Apr 2020 17:48:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-159.ams2.redhat.com [10.36.113.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A7B55C1D2; Fri, 24 Apr 2020 17:48:23 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg/PlatformDebugLibIoPort: Reword QEMU to hypervisor To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Ard Biesheuvel , Jordan Justen , Julien Grall References: <20200423095358.2518197-1-anthony.perard@citrix.com> <20200423095358.2518197-3-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: <7fefc463-498c-defb-3d43-d400616d3da2@redhat.com> Date: Fri, 24 Apr 2020 19:48:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200423095358.2518197-3-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/23/20 11:53, Anthony PERARD wrote: > We are going to reuse PlatformDebugLibIoPort to use debug IO port from > hypervisors that aren't QEMU, so reword "QEMU" to "hypervisor" in the > descriptions. > > Signed-off-by: Anthony PERARD > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h | 2 +- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c | 2 +- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetectRom.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h > index 71a7f33aaf17..4677c85ac3c4 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h > @@ -1,5 +1,5 @@ > /** @file > - Base Debug library instance for QEMU debug port. > + Base Debug library instance for hypervisor debug port. > It uses PrintLib to send debug messages to a fixed I/O port. > > Copyright (c) 2017, Red Hat, Inc.
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > index 3dfa3126c3d0..ec2e677afd8d 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > @@ -1,5 +1,5 @@ > /** @file > - Base Debug library instance for QEMU debug port. > + Base Debug library instance for hypervisor debug port. > It uses PrintLib to send debug messages to a fixed I/O port. > > Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > index 2c659e7aea0a..8c466e64e0a6 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > @@ -1,5 +1,5 @@ > /** @file > - Detection code for QEMU debug port. > + Detection code for hypervisor debug port. > Non-SEC instance, caches the result of detection. > > Copyright (c) 2017, Red Hat, Inc.
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetectRom.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetectRom.c > index 03ba4a0a7b08..8cbdbd94fc0e 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetectRom.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetectRom.c > @@ -1,5 +1,5 @@ > /** @file > - Detection code for QEMU debug port. > + Detection code for hypervisor debug port. > SEC instance, cannot cache the result of detection. > > Copyright (c) 2017, Red Hat, Inc.
> Reviewed-by: Laszlo Ersek