From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0B427740057 for ; Tue, 9 Jan 2024 14:11:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gl1j57Sh4/iX8GSyu4H/ABYHktpKE3BfNfmic+TLeds=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1704809472; v=1; b=PtfRC+27PDZYjXZJwQNO7/8TrTd6RHer9rupyqXn6UFvOSiBXN5ro+GNjQmFOsJgdGw85dZh CcBY3Bvo9FwgDDPSkbCupcFmvzxVRICy0qTl4IYUTwKTSVIBd06R28TcjtGeB0crLVlntSenKwI bxPE65sekUpEaKZaj8DCnbZQ= X-Received: by 127.0.0.2 with SMTP id P19HYY7687511xUcKzoqKIPW; Tue, 09 Jan 2024 06:11:12 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.17447.1704809472132615718 for ; Tue, 09 Jan 2024 06:11:12 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-xzvKc8w6OeWM81hHXame7g-1; Tue, 09 Jan 2024 09:11:08 -0500 X-MC-Unique: xzvKc8w6OeWM81hHXame7g-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A310F38425A5; Tue, 9 Jan 2024 14:11:07 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72BF12166B33; Tue, 9 Jan 2024 14:11:07 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 40693180038B; Tue, 9 Jan 2024 15:11:06 +0100 (CET) Date: Tue, 9 Jan 2024 15:11:06 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Sunil V L , Jiewen Yao , oliver@redhat.com, Andrei Warkentin , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v5 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables Message-ID: <7sym3x3fxx2nxp5wt7we6gqgxl4ngijggsmohmarb3fnozhxtj@cqkijlwl6etg> References: <20240109112902.30002-1-kraxel@redhat.com> <20240109112902.30002-4-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qQzTOGg4KlQtZO4gbKOWr0pGx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PtfRC+27; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > Nit: to my knowledge, the coding style forbids initialization of "auto" > storage class variables (more commonly put, "non-static local > variables"). IOW, we should spell the above as: > > | diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c > | index ca2e40743dfd..8fcd999ac6df 100644 > | --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c > | +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c > | @@ -283,7 +283,9 @@ ValidateFvHeader ( > | > | if (VarHeaderEnd >= VariableStoreHeader->Size) { > | if (VarOffset <= VariableStoreHeader->Size - sizeof (UINT16)) { > | - CONST UINT16 *StartId = (VOID *)((UINTN)VariableStoreHeader + VarOffset); > | + CONST UINT16 *StartId; > | + > | + StartId = (VOID *)((UINTN)VariableStoreHeader + VarOffset); > | if (*StartId == 0x55aa) { > | DEBUG ((DEBUG_ERROR, "%a: startid at invalid location\n", __func__)); > | return EFI_NOT_FOUND; > > Do you want me to fix up the patch upon merge for you, I happily accept that service offer ;) thanks, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113449): https://edk2.groups.io/g/devel/message/113449 Mute This Topic: https://groups.io/mt/103617812/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-