Re: [edk2-devel] [RFC PATCH v3 00/43] SEV-ES guest support

["Lendacky, Thomas" <thomas.lendacky@amd.com>]

On 11/20/19 7:53 PM, Desimone, Nathaniel L wrote:
> Hi Tom,

Hi Nate,

> 
> EFI_CPU_ARCH_PROTOCOL is a PI spec defined protocol. Please see Volume 2, Section 12.3 of the UEFI Platform Initialization Specification. Generally we strictly adhere to the spec when a PPI or protocol is spec defined. If not already done, I would recommend submitting a spec change request with the UEFI Forum. I don't think we can merge the patch series as-is without your change being ratified by the UEFI Forum.
> 
> Another option would be to define a separate protocol with the EDKII_ prefix instead of the EFI_ prefix as the EFI_ prefix is exclusively reserved for PPIs and protocols that are defined by either the UEFI spec or the PI spec. In which case, the protocol would need to be moved to either MdeModulePkg or UefiCpuPkg, as only spec defined PPIs and protocols are allowed in MdePkg.

Thanks for the heads up on this. Lets see if there's any feedback over
email or in the design meeting over what would be the best approach to
take and go from there.

Thanks,
Tom

> 
> Regards,
> Nate
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lendacky, Thomas
> Sent: Wednesday, November 20, 2019 12:06 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Brijesh Singh <brijesh.singh@amd.com>; You, Benjamin <benjamin.you@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong, Guo <guo.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Ma, Maurice <maurice.ma@intel.com>
> Subject: [edk2-devel] [RFC PATCH v3 00/43] SEV-ES guest support
> 
> This patch series provides support for running EDK2/OVMF under SEV-ES.
> 
> Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See
> "AMD64 Architecture Programmer's Manual Volume 2: System Programming", section "15.35 Encrypted State (SEV-ES)" [1].
> 
> In order to allow a hypervisor to perform functions on behalf of a guest, there is architectural support for notifying a guest's operating system when certain types of VMEXITs are about to occur. This allows the guest to selectively share information with the hypervisor to satisfy the requested function. The notification is performed using a new exception, the VMM Communication exception (#VC). The information is shared through the Guest-Hypervisor Communication Block (GHCB) using the VMGEXIT instruction.
> The GHCB format and the protocol for using it is documented in "SEV-ES Guest-Hypervisor Communication Block Standardization" [2].
> 
> The main areas of the EDK2 code that are updated to support SEV-ES are around the exception handling support and the AP boot support.
> 
> Exception support is required starting in Sec, continuing through Pei and into Dxe in order to handle #VC exceptions that are generated.  Each AP requires it's own GHCB page as well as a page to hold values specific to that AP.
> 
> AP booting poses some interesting challenges. The INIT-SIPI-SIPI sequence is typically used to boot the APs. However, the hypervisor is not allowed to update the guest registers. The GHCB document [2] talks about how SMP booting under SEV-ES is performed.
> 
> Since the GHCB page must be a shared (unencrypted) page, the processor must be running in long mode in order for the guest and hypervisor to communicate with each other. As a result, SEV-ES is only supported under the X64 architecture.
> 
> [1] https://www.amd.com/system/files/TechDocs/24593.pdf
> [2] https://developer.amd.com/wp-content/resources/56421.pdf
> 
> ---
> 
> These patches are based on commit:
> cc6854506c2b ("Readme.md: remove positional references from submodule description")
> 
> Proper execution of SEV-ES relies on Bugzilla 2340 being fixed.
> 
> A version of the tree (with an extra patch to workaround Bugzilla 2340) can be found at:
> https://github.com/AMDESE/ovmf/tree/sev-es-v9
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> 
> Changes since v2:
> - Added a way to locate the SEV-ES fixed AP RIP address for starting
>   AP's to avoid updating the actual flash image (build time location
>   that is identified with a GUID value).
> - Create a VmgExit library to replace static inline functions.
> - Move some PCDs to the appropriate packages
> - Add support for writing to QEMU flash under SEV-ES
> - Add additional MMIO opcode support
> - Cleaned up the GHCB MSR CPUID protocol support
> 
> Changes since v1:
> - Patches reworked to be more specific to the component/area being updated
>   and order of definition/usage
> - Created a library for VMGEXIT-related functions to replace use of inline
>   functions
> - Allocation method for GDT changed from AllocatePool to AllocatePages
> - Early caching only enabled for SEV-ES guests
> - Ensure AP loop mode set to halt loop mode for SEV-ES guests
> - Reserved SEC GHCB-related memory areas when S3 is enabled
> 
> Tom Lendacky (43):
>   MdePkg: Create PCDs to be used in support of SEV-ES
>   MdePkg: Add the MSR definition for the GHCB register
>   MdePkg: Add a structure definition for the GHCB
>   MdeModulePkg/DxeIplPeim: Support GHCB pages when creating page tables
>   MdePkg/BaseLib: Add support for the XGETBV instruction
>   MdePkg/BaseLib: Add support for the VMGEXIT instruction
>   UefiCpuPkg: Implement library support for VMGEXIT
>   UefiCpuPkg/CpuExceptionHandler: Add base support for the #VC exception
>   UefiCpuPkg/CpuExceptionHandler: Add support for IOIO_PROT NAE events
>   UefiCpuPkg/CpuExceptionHandler: Support string IO for IOIO_PROT NAE
>     events
>   UefiCpuPkg/CpuExceptionHandler: Add support for CPUID NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for MSR_PROT NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for NPF NAE events (MMIO)
>   UefiCpuPkg/CpuExceptionHandler: Add support for WBINVD NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for RDTSC NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for RDPMC NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for INVD NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for VMMCALL NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for RDTSCP NAE events
>   UefiCpuPkg/CpuExceptionHandler: Add support for MONITOR/MONITORX NAE
>     events
>   UefiCpuPkg/CpuExceptionHandler: Add support for MWAIT/MWAITX NAE
>     events
>   UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE
>     events
>   OvmfPkg/MemEncryptSevLib: Add an SEV-ES guest indicator function
>   OvmfPkg: Add support to perform SEV-ES initialization
>   OvmfPkg/ResetVector: Add support for a 32-bit SEV check
>   OvmfPkg: Create a GHCB page for use during Sec phase
>   OvmfPkg/PlatformPei: Reserve GHCB-related areas if S3 is supported
>   OvmfPkg: Create GHCB pages for use during Pei and Dxe phase
>   OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled
>   OvmfPkg/Sec: Add #VC exception handling for Sec phase
>   OvmfPkg/Sec: Enable cache early to speed up booting
>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with
>     SEV-ES is enabled
>   MdeModulePkg: Reserve a 16-bit protected mode code segment descriptor
>   UefiCpuPkg: Add a 16-bit protected mode code segment descriptor
>   UefiCpuPkg/MpInitLib: Add a CPU MP data flag to indicate if SEV-ES is
>     enabled
>   UefiCpuPkg: Allow AP booting under SEV-ES
>   OvmfPkg: Reserve a page in memory for the SEV-ES AP reset vector
>   OvmfPkg: Move the GHCB allocations into reserved memory
>   MdePkg: Add a finalization function to the CPU protocol
>   UefiCpuPkg/MpInitLib: Add MP finalization interface to MpInitLib
>   UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use
>   UefiCpuPkg/CpuDxe: Provide an DXE MP finalization routine to support
>     SEV-ES
>   MdeModulePkg/DxeCore: Perform the CPU protocol finalization support
> 
>  MdeModulePkg/MdeModulePkg.dec                 |   23 +
>  OvmfPkg/OvmfPkg.dec                           |    5 +
>  UefiCpuPkg/UefiCpuPkg.dec                     |    8 +
>  OvmfPkg/OvmfPkgIa32.dsc                       |   11 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   11 +
>  OvmfPkg/OvmfPkgX64.dsc                        |   11 +
>  UefiCpuPkg/UefiCpuPkg.dsc                     |    5 +
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc         |    2 +
>  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc      |    2 +
>  OvmfPkg/OvmfPkgX64.fdf                        |    9 +
>  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf       |    2 +
>  MdePkg/Library/BaseLib/BaseLib.inf            |    4 +
>  OvmfPkg/PlatformPei/PlatformPei.inf           |    7 +
>  .../FvbServicesRuntimeDxe.inf                 |    2 +
>  OvmfPkg/ResetVector/ResetVector.inf           |    9 +
>  OvmfPkg/Sec/SecMain.inf                       |    1 +
>  .../DxeCpuExceptionHandlerLib.inf             |    5 +
>  .../PeiCpuExceptionHandlerLib.inf             |    5 +
>  .../SecPeiCpuExceptionHandlerLib.inf          |    8 +
>  UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |    4 +
>  UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |    4 +
>  UefiCpuPkg/Library/VmgExitLib/VmgExitLib.inf  |   33 +
>  .../Core/DxeIplPeim/X64/VirtualMemory.h       |   12 +-
>  MdePkg/Include/Library/BaseLib.h              |   31 +
>  MdePkg/Include/Protocol/Cpu.h                 |   18 +
>  MdePkg/Include/Register/Amd/Fam17Msr.h        |   28 +
>  MdePkg/Include/Register/Amd/Ghcb.h            |  117 ++
>  OvmfPkg/Include/Library/MemEncryptSevLib.h    |   12 +
>  UefiCpuPkg/CpuDxe/CpuDxe.h                    |   12 +
>  UefiCpuPkg/CpuDxe/CpuGdt.h                    |    4 +-
>  UefiCpuPkg/Include/Library/MpInitLib.h        |   14 +
>  UefiCpuPkg/Include/Library/VmgExitLib.h       |   96 ++
>  .../CpuExceptionHandlerLib/AMDSevVcCommon.h   |   26 +
>  .../CpuExceptionCommon.h                      |    2 +
>  UefiCpuPkg/Library/MpInitLib/MpLib.h          |   79 +-
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    5 +
>  .../Core/DxeIplPeim/Ia32/DxeLoadFunc.c        |    6 +-
>  .../Core/DxeIplPeim/X64/DxeLoadFunc.c         |   11 +-
>  .../Core/DxeIplPeim/X64/VirtualMemory.c       |   49 +-
>  MdePkg/Library/BaseLib/Ia32/GccInline.c       |   45 +
>  MdePkg/Library/BaseLib/X64/GccInline.c        |   47 +
>  .../MemEncryptSevLibInternal.c                |   77 +-
>  OvmfPkg/PlatformPei/AmdSev.c                  |   82 ++
>  OvmfPkg/PlatformPei/MemDetect.c               |   23 +
>  .../QemuFlash.c                               |   38 +-
>  OvmfPkg/Sec/SecMain.c                         |   74 +-
>  UefiCpuPkg/CpuDxe/CpuDxe.c                    |   21 +-
>  UefiCpuPkg/CpuDxe/CpuGdt.c                    |    8 +-
>  .../CpuExceptionCommon.c                      |    2 +-
>  .../Ia32/AMDSevVcCommon.c                     |   20 +
>  .../PeiDxeAMDSevVcHandler.c                   |   29 +
>  .../PeiDxeSmmCpuException.c                   |   16 +
>  .../SecAMDSevVcHandler.c                      |   50 +
>  .../SecPeiCpuException.c                      |   16 +
>  .../X64/AMDSevVcCommon.c                      | 1230 +++++++++++++++++
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |  136 +-
>  UefiCpuPkg/Library/MpInitLib/MpLib.c          |  280 +++-
>  UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |   35 +
>  UefiCpuPkg/Library/VmgExitLib/VmgExitLib.c    |  132 ++
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c  |    2 +-
>  MdePkg/Library/BaseLib/Ia32/VmgExit.nasm      |   37 +
>  MdePkg/Library/BaseLib/Ia32/XGetBv.nasm       |   31 +
>  MdePkg/Library/BaseLib/X64/VmgExit.nasm       |   32 +
>  MdePkg/Library/BaseLib/X64/XGetBv.nasm        |   34 +
>  OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm  |   94 ++
>  OvmfPkg/ResetVector/Ia32/PageTables64.asm     |  337 ++++-
>  OvmfPkg/ResetVector/ResetVector.nasmb         |   19 +
>  .../X64/ExceptionHandlerAsm.nasm              |   15 +
>  UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc   |    2 +-
>  .../Library/MpInitLib/Ia32/MpFuncs.nasm       |   15 +
>  UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc    |    4 +-
>  UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm |  370 ++++-
>  UefiCpuPkg/Library/VmgExitLib/VmgExitLib.uni  |   15 +
>  .../ResetVector/Vtf0/Ia16/Real16ToFlat32.asm  |    9 +
>  74 files changed, 3969 insertions(+), 101 deletions(-)  create mode 100644 UefiCpuPkg/Library/VmgExitLib/VmgExitLib.inf
>  create mode 100644 MdePkg/Include/Register/Amd/Ghcb.h
>  create mode 100644 UefiCpuPkg/Include/Library/VmgExitLib.h
>  create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/AMDSevVcCommon.h
>  create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/AMDSevVcCommon.c
>  create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeAMDSevVcHandler.c
>  create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/SecAMDSevVcHandler.c
>  create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c
>  create mode 100644 UefiCpuPkg/Library/VmgExitLib/VmgExitLib.c
>  create mode 100644 MdePkg/Library/BaseLib/Ia32/VmgExit.nasm
>  create mode 100644 MdePkg/Library/BaseLib/Ia32/XGetBv.nasm
>  create mode 100644 MdePkg/Library/BaseLib/X64/VmgExit.nasm
>  create mode 100644 MdePkg/Library/BaseLib/X64/XGetBv.nasm
>  create mode 100644 OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm
>  create mode 100644 UefiCpuPkg/Library/VmgExitLib/VmgExitLib.uni
> 
> --
> 2.17.1
> 
> 
> 
>