From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.56720.1669927446352872759 for ; Thu, 01 Dec 2022 12:44:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=dIFkuiSh; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id B948A20B83C2; Thu, 1 Dec 2022 12:44:03 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B948A20B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669927445; bh=AGNMcrdfO2fehHYr+kBBPpJP5X/gx6i5caAhK+WBOOs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dIFkuiShA/9mihaE7fx52+3lWzEkyhMwy72o/IfJqcC1M4uMc937gPAZszwsoaX+Z EJuivyJKVuLJy4N0DeMaydqoxWtx8Sq23zgbdtlvqi0w4eXnJ50VWgIg287iiIeOSL VyJBjWful3FtuDgAMX7CZ268ANtf/YmJrmtd5V4I= Message-ID: <805448d5-8b87-5246-a00e-92b483f17d23@linux.microsoft.com> Date: Thu, 1 Dec 2022 15:44:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v10 12/17] BaseTools: remove ext_dep files for gcc To: devel@edk2.groups.io, osteffen@redhat.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Daniel Schaefer , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Ray Ni , Sami Mujawar , Sean Brogan , Sunil V L , Yuwei Chen , Zhiguang Liu , Pawel Polawski , Chris Fernald References: <20221201202810.109662-1-osteffen@redhat.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 12/1/2022 3:28 PM, Oliver Steffen wrote: > Remove BaseTools/Bin/gcc_*_ext_dep.yaml to stop > downloading gcc from external locations; use the > gcc provided by the container image instead. > The container image sets the variable GCC5_*_PREFIX accordingly. > > Signed-off-by: Oliver Steffen > --- > BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 ------------------ > BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 21 ------------------ > ...gcc_loongarch64_unknown_linux_ext_dep.yaml | 22 ------------------- > .../Bin/gcc_riscv64_unknown_ext_dep.yaml | 22 ------------------- > 4 files changed, 86 deletions(-) > delete mode 100644 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > delete mode 100644 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > delete mode 100644 BaseTools/Bin/gcc_loongarch64_unknown_linux_ext_dep.yaml > delete mode 100644 BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > > diff --git a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > deleted file mode 100644 > index ff8a9e868100..000000000000 > --- a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > +++ /dev/null > @@ -1,21 +0,0 @@ > -## @file > -# Download GCC AARCH64 compiler from Arm's release site > -# Set shell variable GCC5_AARCH64_INSTALL to this folder > -# > -# This is only downloaded when a build activates scope gcc_aarch64_linux > -# > -# Copyright (c) Microsoft Corporation. > -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > -{ > - "scope": "gcc_aarch64_linux", > - "type": "web", > - "name": "gcc_aarch64_linux", > - "source": "https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu.tar.xz", > - "version": "11.2-2022.02", > - "sha256": "52dbac3eb71dbe0916f60a8c5ab9b7dc9b66b3ce513047baa09fae56234e53f3", > - "compression_type": "tar", > - "internal_path": "/gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu/", > - "flags": ["set_shell_var", ], > - "var_name": "GCC5_AARCH64_INSTALL" > -} > diff --git a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > deleted file mode 100644 > index 151cbfa4b532..000000000000 > --- a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > +++ /dev/null > @@ -1,21 +0,0 @@ > -## @file > -# Download GCC ARM compiler from Arm's release site > -# Set shell variable GCC5_ARM_INSTALL to this folder > -# > -# This is only downloaded when a build activates scope gcc_arm_linux > -# > -# Copyright (c) Microsoft Corporation. > -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > -{ > - "scope": "gcc_arm_linux", > - "type": "web", > - "name": "gcc_arm_linux", > - "source": "https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf.tar.xz", > - "version": "11.2-2022.02", > - "sha256": "c254f7199261fe76c32ef42187502839bda7efad0a66646cf739d074eff45fad", > - "compression_type": "tar", > - "internal_path": "/gcc-arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf/", > - "flags": ["set_shell_var", ], > - "var_name": "GCC5_ARM_INSTALL" > -} > diff --git a/BaseTools/Bin/gcc_loongarch64_unknown_linux_ext_dep.yaml > b/BaseTools/Bin/gcc_loongarch64_unknown_linux_ext_dep.yaml > deleted file mode 100644 > index fe9a2448531a..000000000000 > --- a/BaseTools/Bin/gcc_loongarch64_unknown_linux_ext_dep.yaml > +++ /dev/null > @@ -1,22 +0,0 @@ > -## @file > -# Download GCC LoongArch64 compiler from LoongArch GitHub release site > -# Set shell variable GCC5_LOONGARCH64_INSTALL to this folder > -# > -# This is only downloaded when a build activates scope > gcc_loongarch64_unknown_linux > -# > -# Copyright (c) Microsoft Corporation. > -# Copyright (c) 2022, Loongson Technology Corporation Limited. All > rights reserved.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > -{ > - "scope": "gcc_loongarch64_unknown_linux", > - "type": "web", > - "name": "gcc_loongarch64_unknown_linux", > - "source":"https://github.com/loongson/build-tools/releases/download/2022.09.06/loongarch64-clfs-6.3-cross-tools-gcc-full.tar.xz", > - "version": "13.0.0", > - "sha256":"27a43c5bb127794f091d0e75da0003c4d0eec28a958d8f2cc7cd290a6e6133ab", > - "compression_type": "tar", > - "internal_path": "/cross-tools/", > - "flags": ["set_shell_var", ], > - "var_name": "GCC5_LOONGARCH64_INSTALL" > -} > diff --git a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > b/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > deleted file mode 100644 > index 8abbcd7ba040..000000000000 > --- a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > +++ /dev/null > @@ -1,22 +0,0 @@ > -## @file > -# Download GCC RISCV64 compiler from RISC-V Organization release site > -# Set shell variable GCC5_RISCV64_INSTALL to this folder > -# > -# This is only downloaded when a build activates scope gcc_riscv64_unknown > -# > -# Copyright (c) Microsoft Corporation. > -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > rights reserved.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > -{ > - "scope": "gcc_riscv64_unknown", > - "type": "web", > - "name": "gcc_riscv64_unknown", > - "source": "https://raw.githubusercontent.com/riscv/riscv-uefi-edk2-docs/master/gcc-riscv-edk2-ci-toolchain/gcc-riscv-9.2.0-2020.04-x86_64_riscv64-unknown-gnu.tar.xz", > - "version": "9.2.0", > - "compression_type": "tar", > - "sha256": "28373643b69f0ce008273c3dc63f172aa1121952f1b9ae94d7485ac94af7f344", > - "internal_path": "/gcc-riscv-9.2.0-2020.04-x86_64_riscv64-unknown-gnu", > - "flags": ["set_shell_var", ], > - "var_name": "GCC5_RISCV64_INSTALL" > -}