From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 18C3D7803CD for ; Wed, 15 Nov 2023 00:35:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WO22BkS4qO3yWwY+LVb6zVks6OTPzvsr8ZQwcSkyp2I=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700008502; v=1; b=ijYU3ww4IIlMRkTHWdBAhUBUqngvGrgKsKYz/ZiIE0Jh8QRAxKzjGZkzMih6HhBDDBaZIEGg mWTSi1GBAIPakAFiEmJq4SMKY4/pX+chbD20FnYKXu5uGj2BACyh7GpP6ae7AkLn77TOdR5XSXJ VoDpQgMcPMi8S6xeWKxuXgH8= X-Received: by 127.0.0.2 with SMTP id LrcqYY7687511xs4aCaunx2g; Tue, 14 Nov 2023 16:35:02 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2207.1700008502241118459 for ; Tue, 14 Nov 2023 16:35:02 -0800 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 829C920B74C1; Tue, 14 Nov 2023 16:35:01 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 829C920B74C1 Message-ID: <80681e4d-e438-4d2e-be4f-5268920f6211@linux.microsoft.com> Date: Tue, 14 Nov 2023 19:35:00 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] CodeQL Analysis in edk2 To: Laszlo Ersek , devel@edk2.groups.io References: <7c8e4787-74e4-f144-123f-9d44d094ce86@redhat.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 04w4LiBvU9CBfElTLYDd6Djdx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ijYU3ww4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/13/2023 8:42 AM, Laszlo Ersek wrote: > sorry, unfinished thought: >=20 > On 11/13/23 14:39, Laszlo Ersek wrote: >=20 >> - the "sarif emacs" output seems a bit broken, actually, so it's not usa= ble. Consider the following entry from the original JSON file: >> >> }, { >> "ruleId" : "cpp/missing-null-test", >> "ruleIndex" : 0, >> "rule" : { >> "id" : "cpp/missing-null-test", >> "index" : 0 >> }, >> "message" : { >> "text" : "Value may be null; it should be checked before derefe= rencing." >> }, >> "locations" : [ { >> "physicalLocation" : { >> "artifactLocation" : { >> "uri" : "MdeModulePkg/Application/UiApp/FrontPageCustomized= UiSupport.c", >> "uriBaseId" : "%SRCROOT%", >> "index" : 0 >> }, >> "region" : { >> "startLine" : 355, >> "startColumn" : 48, >> "endColumn" : 52 >> } >> } >> } ], >> "partialFingerprints" : { >> "primaryLocationLineHash" : "f374f6e6dfc92010:1", >> "primaryLocationStartColumnFingerprint" : "43" >> } >> }, { >> >> In the "emacs" output, it appears as: >> >> -------- >> ModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c:355: cpp/miss= ing-null-test Value may be null; it should be checked before dereferencing. >> -------- >> >> Note that the first three characters, "Mde" of "Mde" are lost. >=20 > I meant '"Mde" of "ModulePkg"'. >=20 I was able to reproduce this with sarif-tools version 2.0.0. It impacted other commands like "html" as well. Applying the "--no-autotrim" option appears to leave the path alone. Can=20 you please let me know if that works for you? Also, yes, I can add this to the CodeQL GitHub workflow. >> >> This issue (first three chars cut) affects all other pathnames in the em= acs output too. >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111223): https://edk2.groups.io/g/devel/message/111223 Mute This Topic: https://groups.io/mt/102444916/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-