From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.26523.1683619865088148692 for ; Tue, 09 May 2023 01:11:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YAiNdOC3; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683619864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W3bO+JwGHTSFb8ceripxDYZhuiP+POtpwol2Kmt3JQ=; b=YAiNdOC33pNuq/9ETd9KVAKAnxqUmQDdMzj9m96zlk5KnVmCs9o4VnTxSZH7d5Qw/d1N5x Tla3V/QNHzhSTdBlHBNGmMJNC2BI0XThbNe6C6pdT6VdnP2UoXyKcKjm7EbP2bnBMfZlLE JphN+1pUO44BFGxqIe6AA2ckZDpn3hE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-317-_Ex-YrTNMNOAQmbrdKdCDA-1; Tue, 09 May 2023 04:10:59 -0400 X-MC-Unique: _Ex-YrTNMNOAQmbrdKdCDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 743E9800047; Tue, 9 May 2023 08:10:58 +0000 (UTC) Received: from [10.39.192.152] (unknown [10.39.192.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF4792166B26; Tue, 9 May 2023 08:10:55 +0000 (UTC) Message-ID: <808c5e89-8f07-8029-8e84-6f1f33ae2383@redhat.com> Date: Tue, 9 May 2023 10:10:54 +0200 MIME-Version: 1.0 Subject: Re: [PATCH 2/2] OvmfPkg: Replace the OVMF-specific SataControllerDxe with a generic one To: Pedro Falcato , devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?Q?Corvin_K=c3=b6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall References: <20230508215246.217002-1-pedro.falcato@gmail.com> <20230508215246.217002-3-pedro.falcato@gmail.com> From: "Laszlo Ersek" In-Reply-To: <20230508215246.217002-3-pedro.falcato@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/8/23 23:52, Pedro Falcato wrote: > Previously, OVMF had forked DuetPkg's SataControllerDxe (see commit > 12e92a2). However, in commit fda951d a generic SataControllerDxe was > added to MdeModulePkg/Bus/Pci. > Since they are most similar (both code-wise and functionally), let's > unify them and de-duplicate code. > > Tested by booting in QEMU, in both Q35 and PC (to test IDE and AHCI > functionality). > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc :Jordan Justen > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Corvin Köhne > Cc: Sebastien Boeuf > Cc: Anthony Perard > Cc: Julien Grall > Cc: Laszlo Ersek > Signed-off-by: Pedro Falcato > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/Bhyve/BhyveX64.fdf | 2 +- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 2 +- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > OvmfPkg/Microvm/MicrovmX64.fdf | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.fdf | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.fdf | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/OvmfXen.fdf | 2 +- > OvmfPkg/SataControllerDxe/ComponentName.c | 170 --- > OvmfPkg/SataControllerDxe/SataController.c | 1112 ----------------- > OvmfPkg/SataControllerDxe/SataController.h | 544 -------- > .../SataControllerDxe/SataControllerDxe.inf | 43 - > 22 files changed, 18 insertions(+), 1887 deletions(-) > delete mode 100644 OvmfPkg/SataControllerDxe/ComponentName.c > delete mode 100644 OvmfPkg/SataControllerDxe/SataController.c > delete mode 100644 OvmfPkg/SataControllerDxe/SataController.h > delete mode 100644 OvmfPkg/SataControllerDxe/SataControllerDxe.inf Just to make this patch a bit more tractable, I'd suggest splitting it. First, update only the DSC/FDF files. In particular, if you do that alongside review/maintainer responsibilities -- that is, for example, you create a separate FDF+DSC patch for Bhyve and another FDF+DSC patch for Xen --, then your reviewers will thank you for the effort, as they won't have to wade through platform DSC+FDF code they don't care about. Second, removing "OvmfPkg/SataControllerDxe" can be its own patch at the very end of the series; and that one need not be CC'd to the various platform maintainers. With smaller / more focused patches, "GetMaintainer.py" will provide more targeted CC lists. Thanks! Laszlo