public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Richardson, Brian" <brian.richardson@intel.com>
To: Rebecca Cran <rebecca@bluestop.org>,
	"Brian J. Johnson" <brian.johnson@hpe.com>,
	"Wei, David" <david.wei@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Lu, ShifeiX A" <shifeix.a.lu@intel.com>,
	"Zimmer, Vincent" <vincent.zimmer@intel.com>,
	Andrew Fish <afish@apple.com>
Subject: Re: Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?
Date: Thu, 23 Feb 2017 23:11:09 +0000	[thread overview]
Message-ID: <80AC2BAA3152784F98F581129E5CF5AF665616CD@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <e2e07aef-aefa-32da-87bc-60237bf7efa2@bluestop.org>

One thing we can try is automating the right setting for MAX_CONCURRENT_THREAD_NUMBER. In Windows, there's a command line utility to return the number of logical processors.

	C:\Users\sample>wmic cpu get numberoflogicalprocessors
	NumberOfLogicalProcessors
	4 

This could be used to set MAX_CONCURRENT_THREAD_NUMBER (NumberOfLogicalProcessors+1, so 5 in this case) automagically in target.txt (via edksetup.bat) or as a command line parameter (in BuildBios.bat). I'm sure there's an equivalent shell command in Linux that can be co-opted for our purposes.

Thoughts?

Thanks ... br
---
Brian Richardson, Senior Technical Marketing Engineer, Intel Software
brian.richardson@intel.com -- @intel_Brian (Twitter & WeChat)
https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson 

-----Original Message-----
From: Rebecca Cran [mailto:rebecca@bluestop.org] 
Sent: Thursday, February 23, 2017 2:10 PM
To: Brian J. Johnson <brian.johnson@hpe.com>; Wei, David <david.wei@intel.com>; Richardson, Brian <brian.richardson@intel.com>; Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
Cc: Lu, ShifeiX A <shifeix.a.lu@intel.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; Andrew Fish <afish@apple.com>
Subject: Re: [edk2] Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?

On 2/23/2017 11:53 AM, Brian J. Johnson wrote:

> Sorry if I'm bikeshedding...  NUMBER_OF_PROCESSORS isn't a good 
> default for those of us who build on servers with hundreds of threads 
> available.  The OS, disks, and build.exe/build.py become bottlenecks.
> Maybe we could put a cap (say, 20) on the default thread limit, so it 
> uses NUMBER_OF_PROCESSORS or 20 threads, whichever is less.
>
> Or just set a small, fixed number of threads by default and document 
> better how to change it, as others suggested.

Good point. I think the best approach will be to have a --setup parameter which configures defaults in Conf/target.txt, after which users can change MAX_CONCURRENT_THREAD_NUMBER - instead of the current method which involves figuring out which of files ends up running build.exe with '-n <threads>'.

-- 
Rebecca


      reply	other threads:[~2017-02-23 23:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  1:20 Improvements to build system etc. for edk2-platforms devel-MinnowBoard3? Rebecca Cran
2017-02-22  4:50 ` Gao, Liming
2017-02-22  5:11   ` Andrew Fish
2017-02-22  5:48   ` Rebecca Cran
2017-02-22  7:35     ` Gao, Liming
2017-02-22 16:34     ` Richardson, Brian
2017-02-22 16:52       ` Rebecca Cran
2017-02-22 19:10         ` Richardson, Brian
2017-02-23  2:49           ` Wei, David
2017-02-23 18:53             ` Brian J. Johnson
2017-02-23 19:10               ` Rebecca Cran
2017-02-23 23:11                 ` Richardson, Brian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80AC2BAA3152784F98F581129E5CF5AF665616CD@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox