From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5706A21E1DAC7 for ; Thu, 3 Aug 2017 11:24:38 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2017 11:26:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,317,1498546800"; d="scan'208";a="295426758" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga004.fm.intel.com with ESMTP; 03 Aug 2017 11:26:34 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 11:26:34 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.216]) by ORSMSX162.amr.corp.intel.com ([169.254.3.52]) with mapi id 14.03.0319.002; Thu, 3 Aug 2017 11:26:34 -0700 From: "Richardson, Brian" To: "Ni, Ruiyu" , "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , Andrew Fish Thread-Topic: [edk2] [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined Thread-Index: AQHTC3G925fwCGO1dUWRka56gU59yKJx3GKQgAEYUDA= Date: Thu, 3 Aug 2017 18:26:34 +0000 Message-ID: <80AC2BAA3152784F98F581129E5CF5AF8E97894D@ORSMSX114.amr.corp.intel.com> References: <1501666085-21208-1-git-send-email-yonghong.zhu@intel.com> <1501666085-21208-3-git-send-email-yonghong.zhu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5B9C9580@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B9C9580@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWEwODBjMWMtMzY4My00ODNmLWJkMjMtNzAzZDVjODRhMzEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdDb25hU2xUK2hMUVwvZ0Z5bWJvdmFTQkVsaUl3bXJDZ2ZKZkozNjVjclJZPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 18:24:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I thought we considered this an obsolete package. https://github.com/tianocore/tianocore.github.io/wiki/DuetPkg=20 If this package is obsolete, the readme needs to be updated to reflect this= information. https://github.com/tianocore/edk2/tree/master/DuetPkg=20 Thanks ... br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richardson@intel.com -- @intel_brian (Twitter & WeChat) https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian= -richardson=20 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni, = Ruiyu Sent: Wednesday, August 2, 2017 9:42 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Andrew Fish Subject: Re: [edk2] [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit l= eft shift as undefined I am surprised DuetPkg is still being used. Reviewed-by: Ruiyu Ni Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yon= ghong Zhu >Sent: Wednesday, August 2, 2017 5:28 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Wu, Hao A ; Andrew= Fish >Subject: [edk2] [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left= shift as undefined > >Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=3D635 > >Cc: Ruiyu Ni >Cc: Hao Wu >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Andrew Fish >--- > DuetPkg/EfiLdr/TianoDecompress.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/DuetPkg/EfiLdr/TianoDecompress.c b/DuetPkg/EfiLdr/TianoDecomp= ress.c >index b504e8e..86d82fc 100644 >--- a/DuetPkg/EfiLdr/TianoDecompress.c >+++ b/DuetPkg/EfiLdr/TianoDecompress.c >@@ -91,15 +91,15 @@ Arguments: > > Returns: (VOID) > > --*/ > { >- Sd->mBitBuf =3D (UINT32) (Sd->mBitBuf << NumOfBits); >+ Sd->mBitBuf =3D (UINT32) (((UINT64)Sd->mBitBuf) << NumOfBits); > > while (NumOfBits > Sd->mBitCount) { > >- Sd->mBitBuf |=3D (UINT32) (Sd->mSubBitBuf << (NumOfBits =3D (UINT16) = (NumOfBits - Sd->mBitCount))); >+ Sd->mBitBuf |=3D (UINT32) (((UINT64)Sd->mSubBitBuf) << (NumOfBits =3D= (UINT16) (NumOfBits - Sd->mBitCount))); > > if (Sd->mCompSize > 0) { > // > // Get 1 byte into SubBitBuf > // >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel