From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=brian.richardson@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A7FC0220C1C5F for ; Thu, 30 Nov 2017 06:57:19 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2017 07:01:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,341,1508828400"; d="scan'208";a="7973583" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga004.fm.intel.com with ESMTP; 30 Nov 2017 07:01:44 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.129]) by ORSMSX107.amr.corp.intel.com ([169.254.1.228]) with mapi id 14.03.0319.002; Thu, 30 Nov 2017 07:01:43 -0800 From: "Richardson, Brian" To: Karunakar P , "Wu, Jiaxin" , "Fu, Siyuan" , "Ye, Ting" , "'edk2-devel@lists.01.org'" Thread-Topic: DHCP Process Starts Even there is NO Media Connected Thread-Index: AdNkNPJlNii6MXEqST2sZcqbh3p1FwDG32fwAELhS7AAH1I1YAAyTPpQABG0g5A= Date: Thu, 30 Nov 2017 15:01:42 +0000 Message-ID: <80AC2BAA3152784F98F581129E5CF5AFA464ACA2@ORSMSX114.amr.corp.intel.com> References: <895558F6EA4E3B41AC93A00D163B72741634DAB3@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU4MTMyMTMtNjJmOS00Nzk5LWJiZDEtYTdhN2Q1OWM1MzY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZMZmFiOGZBazcrVjRkME5xK2ZUNVJLR2FKMmlCZlVIUTBSMGdiTWJ1a1U9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: DHCP Process Starts Even there is NO Media Connected X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 14:57:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We saw some problems running Linux UEFI Validation (LUV) at the last UEFI P= lugfest that are probably related to this issue. At the time we asked the L= UV team to investigate it as a test issue, but it may actually be a stack p= roblem based on this information. Have you filed a tracker in TianoCore Bugzilla for this issue? Thanks ... br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richardson@intel.com -- @intel_brian (Twitter & WeChat) https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian= -richardson=20 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Karu= nakar P Sent: Thursday, November 30, 2017 3:59 AM To: Wu, Jiaxin ; Fu, Siyuan ; Ye,= Ting ; 'edk2-devel@lists.01.org' Subject: Re: [edk2] DHCP Process Starts Even there is NO Media Connected Hi Jiaxin, Please find my below comments/suggestions. 1. Yes, Current DHCP4/6 Start() implementation doesn't check for Medi= a Status. It will be better to implement it in order to sync with UEFI spec= . 2. DHCP process may be initiated by HTTP/PXE/ISCSI or Assigning IP (S= etData) from Shell or using BIOS setup page. HTTP,PXE and ISCSI is already Checking Media Presence before DHCP Start, So= it will have NO effect if we do implementation in DHCP4/6 Start(). 3. Current implementation of EFI_IP4_CONFIG2_SET_DATA, also NOT handl= ing checking Media Status. a. UEFI Spec NOT defines EFI_NO_MEDIA status code for EFI_IP4_CONFIG2= _SET_DATA, I'm NOT sure what's reason behind it or might be missing. b. UEFI Spec defines EFI_DEVICE_ERROR status code for EFI_IP4_CONFIG2_= SET_DATA, If we can use the same status for Media presence then no issues. c. When there is No Media connected and if we try to assign IP over D= HCP(SetData), I guess there is no need to proceed further in EfiIp4Config2S= etData and we can return with EFI_DEVICE_ERROR. Based on above points(1 & 3.c ), I've updated the suggested changes and att= ached the same (CheckMediaStatus_V2.rar) Could you please review and provide your comments. Please correct if anything wrong. Thank You, Karunakar From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] Sent: Wednesday, November 29, 2017 11:57 AM To: Karunakar P; Fu, Siyuan; Ye, Ting Subject: RE: DHCP Process Starts Even there is NO Media Connected Hi Karunakar, After talk with Siyuan, we agree it's reasonable to check the Media status = before starting DHCP process, but we'd better check it in DHCP layer since = the UEFI spec defines EFI_NO_MEDIA status code for DHCP4/6.Start(), but our= current implementation doesn't check it. What do you think? Thanks, Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Tuesday, November 28, 2017 11:18 PM To: Wu, Jiaxin >; Fu, Siyua= n >; Ye, Ting > Subject: RE: DHCP Process Starts Even there is NO Media Connected Could you please review the attachment changes for this support. Thanks, Karunakar From: Karunakar P Sent: Monday, November 27, 2017 12:53 PM To: 'Wu, Jiaxin'; 'Fu, Siyuan'; 'Ye, Ting' Subject: RE: DHCP Process Starts Even there is NO Media Connected Could you please provide your comments... Thank You, Karunakar From: Karunakar P Sent: Thursday, November 23, 2017 2:05 PM To: 'Wu, Jiaxin'; Fu, Siyuan; Ye, Ting Subject: DHCP Process Starts Even there is NO Media Connected Hello All, When we try to Assign IP to SUT using ifconfig command from Shell or IPv4 = Network Configuration BIOS setup page DHCP process start even there is no L= AN cable connected to specific port. Can we add a Media presence condition check before starting DHCP service? Could you please correct if anything is wrong. Thanks, Karunakar _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel