From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 67DFE7803CF for ; Tue, 5 Sep 2023 16:05:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1mtMLjpPTckROjbygCUkVzr9gd1textOeSi5fIBhbD0=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693929939; v=1; b=B8bLR6/mPPreDXkdkqdCzOoaygwoKco6rE4Uea2rywZgee8cjJ3EcpMZcX9xZl0BV/yV36n1 5yp+GuIrf6vWa/+pMXFwtkrCtZNezNzAQo4va/sWc+MKgqgO131gyh29mrRdCpUhusMK6DK2egl RyfWEd8aky3Gi7Ub9E/BtB5s= X-Received: by 127.0.0.2 with SMTP id ADppYY7687511xphYuENz28p; Tue, 05 Sep 2023 09:05:39 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.25676.1693929938000424038 for ; Tue, 05 Sep 2023 09:05:38 -0700 X-Received: from [10.137.194.171] (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 33D05212B17D; Tue, 5 Sep 2023 09:05:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 33D05212B17D Message-ID: <80b6f01c-7708-4ddb-ba58-c644fbfd1730@linux.microsoft.com> Date: Tue, 5 Sep 2023 09:05:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v1 1/1] ArmVirtPkg: ArmVirtQemu: Add Graphics and Input To: devel@edk2.groups.io, ardb@kernel.org Cc: Leif Lindholm , Sami Mujawar , Gerd Hoffmann References: <20230818181751.12308-1-osde@linux.microsoft.com> From: "Oliver Smith-Denny" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9y73xmRoPGeMldfvRfqk80g2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="B8bLR6/m"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Gentle reminder on this now that the stable tag has passed. Thanks, Oliver On 8/18/2023 2:05 PM, Ard Biesheuvel wrote: > On Fri, 18 Aug 2023 at 20:17, Oliver Smith-Denny > wrote: >> >> Currently, unlike OVMF, ArmVirtQemu does not display any graphics, >> only the QEMU monitor. Graphics are helpful to confirm booting into >> an OS is successful, interacting with the EFI shell while getting >> separate logging messages, etc. >> >> This patch adds the QEMU parameters to launch a graphical window >> and add a USB keyboard and mouse, which is modeled as a tablet as >> it tracks better in QEMU than a generic mouse. virtio-gpu-pci is >> chosen as the graphics device as it is recommended by QEMU for the >> ARM virtual platform. >> >> The graphics and USB input devices will only be added to QEMU when >> QEMU_HEADLESS =3D=3D FALSE, so CI builds will not attempt to use the >> graphics and if a user does not want graphics, they can add >> QEMU_HEADLESS=3DTRUE to the build cmdline. >> >> GitHub PR: https://github.com/tianocore/edk2/pull/4750 >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Gerd Hoffmann >> >> Signed-off-by: Oliver Smith-Denny >=20 > Reviewed-by: Ard Biesheuvel >=20 > Feel free to remind me to queue this up after the stable tag release. >=20 >=20 >> --- >> ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py b/ArmVirtPkg/Plat= formCI/PlatformBuildLib.py >> index 405817cae785..0ddaccf9c21f 100644 >> --- a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py >> +++ b/ArmVirtPkg/PlatformCI/PlatformBuildLib.py >> @@ -244,6 +244,11 @@ class PlatformBuilder(UefiBuilder, BuildSettingsMan= ager): >> # Conditional Args >> if (self.env.GetValue("QEMU_HEADLESS").upper() =3D=3D "TRUE"): >> args +=3D " -display none" # no graphics >> + else: >> + args +=3D " -device virtio-gpu-pci" = # add recommended QEMU graphics device >> + args +=3D " -device qemu-xhci,id=3Dusb" = # add USB support for below devices >> + args +=3D " -device usb-tablet,id=3Dinput0,bus=3Dusb.0,port= =3D1" # add a usb mouse >> + args +=3D " -device usb-kbd,id=3Dinput1,bus=3Dusb.0,port=3D= 2" # add a usb keyboard >> >> if (self.env.GetValue("MAKE_STARTUP_NSH").upper() =3D=3D "TRUE= "): >> f =3D open(os.path.join(VirtualDrive, "startup.nsh"), "w") >> -- >> 2.40.1 >> >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108291): https://edk2.groups.io/g/devel/message/108291 Mute This Topic: https://groups.io/mt/100826022/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-