From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.2427.1574678884524234980 for ; Mon, 25 Nov 2019 02:48:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dnHY4Pfa; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574678883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZqXclZ4nfPay5/5Y/nbwqd9NhclfNbF4qwoKFNS/5sM=; b=dnHY4Pfarh4kzybQQa50newReRlOYbcFxDiKU5FelPs5OdLvsVbXPv1S1bzF+fEvuEKDRS Yful0YPvnRPsPndKZQFfqMbrTCTsvyVPTAI0oJdqrBo22aoNDF71L7r1y0FhOBMTkfthQJ JwLTipet9kJxzOELxE2XnWWZ5IWdFKQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-XcjrtUL8Oty8gdn-C72Y5g-1; Mon, 25 Nov 2019 05:48:00 -0500 Received: by mail-wm1-f71.google.com with SMTP id p19so5154704wma.8 for ; Mon, 25 Nov 2019 02:48:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rKRd5FabOiF3aGiQBEiKJL7CdClCzSYOwJiu66ahZt4=; b=aeCJvm0UG3deY24TaCDZXrS0T2Aj1wyxCBBG5ClwLiAr0llsxKeFsRhBLUZSy0sMAJ t4Ve1RMxJMlbAqxsogKH5TQkn2e5NAQxTWGcKagCNSlyxFk/lcQ29Ms/XQf4om80RPag XaeHtauBVbiqu0YA34263vkyQoy1URcu5jJCpdAlwvlB/6lTa7lqgZQAFjGtOLmosgVQ Kd479NaZt58KaQpCE+GxLvOki4FdZGsY4+vT3ODAzn8VR+q9hy2yHvnwDF3h3DHqH28K p1ZPrt72BiRmOInF1U/L+KpcnwbfF6p+JI6TxfZVOe+UefjDOut0ZY2Fp0piVCqcXpVr TMDA== X-Gm-Message-State: APjAAAXSmArlP35lv/DKgtEw7UeBnB1s9DMw7RiBYgi+YDxvBuGATVfG dtyBGF6imMP2jZ85G/z0hwzY+Aj7wpcOqyw0j2d2CoW53CKMYmyFRrKJjoXdiuA9uNzgP4I7o9j 7dyLqCCy8e7n3kw== X-Received: by 2002:adf:ed11:: with SMTP id a17mr31872680wro.392.1574678879021; Mon, 25 Nov 2019 02:47:59 -0800 (PST) X-Google-Smtp-Source: APXvYqz4HZ/BFrrJ9Gf5/9LKFHq+3e0ezwSOsw2pvrjSsdEmcRaA4ZZdKa6mDvbzi3DS8rh8Js/UaA== X-Received: by 2002:adf:ed11:: with SMTP id a17mr31872648wro.392.1574678878718; Mon, 25 Nov 2019 02:47:58 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id s8sm7708075wmc.39.2019.11.25.02.47.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Nov 2019 02:47:58 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: achin.gupta@arm.com, jiewen.yao@intel.com, supreeth.venkatesh@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20191125092609.15060-1-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <80c1b0c2-e85e-daa0-4ba1-ed5344e9f688@redhat.com> Date: Mon, 25 Nov 2019 11:47:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191125092609.15060-1-sami.mujawar@arm.com> X-MC-Unique: XcjrtUL8Oty8gdn-C72Y5g-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Hi Sami, On 11/25/19 10:26 AM, Sami Mujawar via Groups.Io wrote: > The Basetools scripts have been updated to report > warnings if header files are not listed in the > [Sources] section of the inf files. >=20 > Update StandaloneMmCpu.inf to include the header > file StandaloneMmCpu.h to fix the warning. >=20 > Cc: Achin Gupta > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1 >=20 > Notes: > v2: > - Fixed patch check failure in commit message, [SAM= I] > changed 'CC' to 'Cc'. No code change. No code change, please keep the reviewer tags so we don't have to review=20 the same patch again. I reviewed this one, see: https://www.mail-archive.com/devel@edk2.groups.io/msg11976.html Again: Reviewed-by: Philippe Mathieu-Daude > v1: > - Fix missing header warnings [SAM= I] >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3= ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMm= Cpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i= nf > index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f495= 71e02c9e1e427ce 100644 > --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > @@ -4,7 +4,7 @@ > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> # Copyright (c) 2016 HP Development Company, L.P. > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +21,7 @@ [Defines] > =20 > [Sources] > StandaloneMmCpu.c > + StandaloneMmCpu.h > EventHandle.c > =20 > [Packages] >=20