[PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning

[PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Sami Mujawar]

The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.

Update StandaloneMmCpu.inf to include the header
file StandaloneMmCpu.h to fix the warning.

Cc: Achin Gupta <achin.gupta@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1

Notes:
    v2:
      - Fixed patch check failure in commit message,                [SAMI]
          changed 'CC' to 'Cc'. No code change.
    v1:
      - Fix missing header warnings                                 [SAMI]

 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e02c9e1e427ce 100644
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
@@ -4,7 +4,7 @@
 #
 #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
 #  Copyright (c) 2016 HP Development Company, L.P.
-#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -21,6 +21,7 @@ [Defines]
 
 [Sources]
   StandaloneMmCpu.c
+  StandaloneMmCpu.h
   EventHandle.c
 
 [Packages]
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Philippe Mathieu-Daudé]

Hi Sami,

On 11/25/19 10:26 AM, Sami Mujawar via Groups.Io wrote:
> The Basetools scripts have been updated to report
> warnings if header files are not listed in the
> [Sources] section of the inf files.
> 
> Update StandaloneMmCpu.inf to include the header
> file StandaloneMmCpu.h to fix the warning.
> 
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1
> 
> Notes:
>      v2:
>        - Fixed patch check failure in commit message,                [SAMI]
>            changed 'CC' to 'Cc'. No code change.

No code change, please keep the reviewer tags so we don't have to review 
the same patch again. I reviewed this one, see:
https://www.mail-archive.com/devel@edk2.groups.io/msg11976.html
Again:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>      v1:
>        - Fix missing header warnings                                 [SAMI]
> 
>   StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e02c9e1e427ce 100644
> --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> @@ -4,7 +4,7 @@
>   #
>   #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
>   #  Copyright (c) 2016 HP Development Company, L.P.
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -21,6 +21,7 @@ [Defines]
>   
>   [Sources]
>     StandaloneMmCpu.c
> +  StandaloneMmCpu.h
>     EventHandle.c
>   
>   [Packages]
> 

Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Sami Mujawar]

Hi Philippe,

Apologies, I missed #28 from Laszlo's guide.

This patch has also received a r-b from:
      Reviewed-by: Jiewen.yao@intel.com

Regards,

Sami Mujawar

-----Original Message-----
From: Philippe Mathieu-Daudé <philmd@redhat.com> 
Sent: 25 November 2019 10:48 AM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Achin Gupta <Achin.Gupta@arm.com>; jiewen.yao@intel.com; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning

Hi Sami,

On 11/25/19 10:26 AM, Sami Mujawar via Groups.Io wrote:
> The Basetools scripts have been updated to report warnings if header 
> files are not listed in the [Sources] section of the inf files.
> 
> Update StandaloneMmCpu.inf to include the header file 
> StandaloneMmCpu.h to fix the warning.
> 
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_
> v1
> 
> Notes:
>      v2:
>        - Fixed patch check failure in commit message,                [SAMI]
>            changed 'CC' to 'Cc'. No code change.

No code change, please keep the reviewer tags so we don't have to review the same patch again. I reviewed this one, see:
https://www.mail-archive.com/devel@edk2.groups.io/msg11976.html
Again:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>      v1:
>        - Fix missing header warnings                                 [SAMI]
> 
>   StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git 
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf 
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> index 
> 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e
> 02c9e1e427ce 100644
> --- 
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> +++ inf
> @@ -4,7 +4,7 @@
>   #
>   #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
>   #  Copyright (c) 2016 HP Development Company, L.P.
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -21,6 +21,7 @@ [Defines]
>   
>   [Sources]
>     StandaloneMmCpu.c
> +  StandaloneMmCpu.h
>     EventHandle.c
>   
>   [Packages]
>