From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 306C421B02845 for ; Fri, 6 Jul 2018 11:48:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3FFE401DE6F; Fri, 6 Jul 2018 18:48:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-154.rdu2.redhat.com [10.10.120.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27C162166BA9; Fri, 6 Jul 2018 18:48:40 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Lendacky Thomas , Ard Biesheuvel , Anthony Perard , Julien Grall , Justen Jordan L References: <1530889242-21667-1-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <80de9c9a-0c63-25a1-e79b-22ea0ff26fc0@redhat.com> Date: Fri, 6 Jul 2018 20:48:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1530889242-21667-1-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 06 Jul 2018 18:48:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 06 Jul 2018 18:48:42 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 18:48:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/06/18 17:00, Brijesh Singh wrote: > The Qemu flash range is marked as 'system ram' in EFI runtime memmap > but it is actually an IO address. The patch series updates the > EFI runtime memmap to add this range as Memory Mapped IO address. > > Changes since v3: > - minor changes to address Laszlo's review feedback. > > Changes since v2: > - added cover letter and extend CC list to add all OvmfPkg > maintainers/reviewers. > > Changes since v1: > - split the OvmfPkg single patch into three patches based on Laszlo's feedback. > a) mark memory as MMIO for non SEV case > b) do not adding EFI runtime mapping for SMM build > c) clear C-bit when SEV is active for non SMM builds only > > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: Justen Jordan L > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > > Complete tree is available: > url: https://github.com/codomania/edk2.git > branch: qemu-flash-mmio-v4 > > Brijesh Singh (3): > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as > MMIO > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM > build > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is > active > > .../FvbServicesRuntimeDxe.inf | 1 + > .../FwBlockService.c | 38 +----------- > .../FwBlockService.h | 7 +++ > .../FwBlockServiceDxe.c | 67 ++++++++++++++++++++++ > .../FwBlockServiceSmm.c | 13 +++++ > 5 files changed, 89 insertions(+), 37 deletions(-) > series Reviewed-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek Commit range 9090c8b53301..75b7aa9528bd. Thank you for the contribution! The first two patches are a good general improvement for non-SEV guests as well. Laszlo