Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Rebecca,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 16/12/2021, 13:14, "Rebecca Cran" <rebecca@nuviainc.com> wrote:

    On 12/16/21 2:32 AM, Ard Biesheuvel wrote:

    > You appear to have missed a few instances:
    >
    > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
    > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
    > Platform/Hisilicon/D03/D03.dsc
    > Platform/Hisilicon/D05/D05.dsc
    > Platform/Hisilicon/D06/D06.dsc
    > Platform/Hisilicon/HiKey/HiKey.dsc
    > Platform/Hisilicon/HiKey960/HiKey960.dsc
    > Platform/LeMaker/CelloBoard/CelloBoard.dsc
    > Platform/Phytium/DurianPkg/DurianPkg.dsc
    > Platform/RaspberryPi/RPi3/RPi3.dsc
    > Platform/RaspberryPi/RPi4/RPi4.dsc
    > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
    >
    > I know this is tedious busywork, but you can't break existing
    > platforms like that, so please provide a solution for these as well.

    Thanks, I'm not sure how I managed to miss those. I'll send out a v2 
    patch with them included.

    I agree, I can't break platforms like this.


    I'm also keeping track of platforms that are currently broken in other 
    ways, such as 
    Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs 
    updated for the VariablePolicyHelperLib, and 
    Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem. 
    Several other platforms claim to support ARM but don't currently build. 
    For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with:


      : error F000: No files to be built in module [RELEASE, GCC5, ARM]
    [/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf]

[SAMI] I posted the following patches to fix some of the issues you mention above:
Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://edk2.groups.io/g/devel/message/83553)
Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.io/g/devel/message/83556)
Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (https://edk2.groups.io/g/devel/message/83554)
Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32  Builds (https://edk2.groups.io/g/devel/message/83557)

If it helps, I can carve out these patches in a separate series and post them to the list.

I feel we need a CI for edk2-platforms. Without this it is going to be hard to keep track of such build breaks.
[/SAMI]

    -- 
    Rebecca Cran