From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24D0D209603CA for ; Tue, 22 May 2018 05:48:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75B51814F0A8; Tue, 22 May 2018 12:48:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-18.rdu2.redhat.com [10.10.120.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7934F8579B; Tue, 22 May 2018 12:48:11 +0000 (UTC) To: marcandre.lureau@redhat.com, edk2-devel@lists.01.org Cc: qemu-devel@nongnu.org, javierm@redhat.com, pjones@redhat.com, jiewen.yao@intel.com References: <20180518122304.31020-1-marcandre.lureau@redhat.com> <20180518122304.31020-2-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: <811a060f-ea14-48c9-ceb2-b27b45bbc431@redhat.com> Date: Tue, 22 May 2018 14:48:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180518122304.31020-2-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 22 May 2018 12:48:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 22 May 2018 12:48:17 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v3 1/4] OvmfPkg: add Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 12:48:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/18/18 14:23, marcandre.lureau@redhat.com wrote: > diff --git a/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf b/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > new file mode 100644 > index 000000000000..92ce5f04b37f > --- /dev/null > +++ b/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > @@ -0,0 +1,33 @@ > +## @file > +# NULL Tcg2PhysicalPresenceLib library instance > +# > +# Under SecurityPkg, the corresponding library instance will check and > +# execute TPM 2.0 request from OS or BIOS; the request may ask for user > +# confirmation before execution. This Null instance implements a no-op > +# Tcg2PhysicalPresenceLibProcessRequest(), without user interaction. > +# > +# Copyright (C) 2018, Red Hat, Inc. > +# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +## > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = DxeTcg2PhysicalPresenceLibNull > + FILE_GUID = 2A6BA243-DC22-42D8-9C3D-AE3728DC7AFA > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = Tcg2PhysicalPresenceLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER UEFI_APPLICATION UEFI_DRIVER > + > +[Sources] > + DxeTcg2PhysicalPresenceLib.c > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + SecurityPkg/SecurityPkg.dec Here my suggestion was to drop MdeModulePkg.dec, and keep MdePkg.dec and SecurityPkg.dec. Anyway, I plan to fix that up for you. With it fixed: Reviewed-by: Laszlo Ersek Thanks Laszlo