* [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name.
@ 2020-11-12 1:33 gechao
2020-11-12 1:39 ` 回复: " gaoliming
[not found] ` <16469F0A5D9CED83.27022@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: gechao @ 2020-11-12 1:33 UTC (permalink / raw)
To: devel; +Cc: dandan.bi, eric.dong, gaoliming, gechao
From: gechao <gechao@greatwall.com.cn>
Signed-off-by: gechao <gechao@greatwall.com.cn>
---
.../Universal/DisplayEngineDxe/FormDisplay.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
index 3b034a1c82..a3898dc2ec 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
@@ -372,7 +372,7 @@ GetWidth (
{
CHAR16 *String;
UINTN Size;
- EFI_IFR_TEXT *TestOp;
+ EFI_IFR_TEXT *TextOp;
UINT16 ReturnWidth;
FORM_DISPLAY_ENGINE_STATEMENT *Statement;
@@ -394,9 +394,9 @@ GetWidth (
// See if the second text parameter is really NULL
//
if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
- TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
- if (TestOp->TextTwo != 0) {
- String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
+ TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
+ if (TextOp->TextTwo != 0) {
+ String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
Size = StrLen (String);
FreePool (String);
}
@@ -2166,7 +2166,7 @@ HasOptionString (
FORM_DISPLAY_ENGINE_STATEMENT *Statement;
CHAR16 *String;
UINTN Size;
- EFI_IFR_TEXT *TestOp;
+ EFI_IFR_TEXT *TextOp;
Size = 0;
Statement = MenuOption->ThisTag;
@@ -2175,9 +2175,9 @@ HasOptionString (
// See if the second text parameter is really NULL
//
if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
- TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
- if (TestOp->TextTwo != 0) {
- String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
+ TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
+ if (TextOp->TextTwo != 0) {
+ String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
Size = StrLen (String);
FreePool (String);
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* 回复: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name.
2020-11-12 1:33 [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name gechao
@ 2020-11-12 1:39 ` gaoliming
[not found] ` <16469F0A5D9CED83.27022@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: gaoliming @ 2020-11-12 1:39 UTC (permalink / raw)
To: gechao, devel; +Cc: dandan.bi, eric.dong
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: gechao@greatwall.com.cn <gechao@greatwall.com.cn>
> 发送时间: 2020年11月12日 9:34
> 收件人: devel@edk2.groups.io
> 抄送: dandan.bi@intel.com; eric.dong@intel.com;
> gaoliming@byosoft.com.cn; gechao <gechao@greatwall.com.cn>
> 主题: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable
> name.
>
> From: gechao <gechao@greatwall.com.cn>
>
> Signed-off-by: gechao <gechao@greatwall.com.cn>
> ---
> .../Universal/DisplayEngineDxe/FormDisplay.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> index 3b034a1c82..a3898dc2ec 100644
> --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> @@ -372,7 +372,7 @@ GetWidth (
> {
>
> CHAR16 *String;
>
> UINTN Size;
>
> - EFI_IFR_TEXT *TestOp;
>
> + EFI_IFR_TEXT *TextOp;
>
> UINT16 ReturnWidth;
>
> FORM_DISPLAY_ENGINE_STATEMENT *Statement;
>
>
>
> @@ -394,9 +394,9 @@ GetWidth (
> // See if the second text parameter is really NULL
>
> //
>
> if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
>
> - TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
>
> - if (TestOp->TextTwo != 0) {
>
> - String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
>
> + TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
>
> + if (TextOp->TextTwo != 0) {
>
> + String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
>
> Size = StrLen (String);
>
> FreePool (String);
>
> }
>
> @@ -2166,7 +2166,7 @@ HasOptionString (
> FORM_DISPLAY_ENGINE_STATEMENT *Statement;
>
> CHAR16 *String;
>
> UINTN Size;
>
> - EFI_IFR_TEXT *TestOp;
>
> + EFI_IFR_TEXT *TextOp;
>
>
>
> Size = 0;
>
> Statement = MenuOption->ThisTag;
>
> @@ -2175,9 +2175,9 @@ HasOptionString (
> // See if the second text parameter is really NULL
>
> //
>
> if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
>
> - TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
>
> - if (TestOp->TextTwo != 0) {
>
> - String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
>
> + TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
>
> + if (TextOp->TextTwo != 0) {
>
> + String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
>
> Size = StrLen (String);
>
> FreePool (String);
>
> }
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <16469F0A5D9CED83.27022@groups.io>]
* 回复: [edk2-devel] 回复: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name.
[not found] ` <16469F0A5D9CED83.27022@groups.io>
@ 2020-11-12 14:29 ` gaoliming
0 siblings, 0 replies; 3+ messages in thread
From: gaoliming @ 2020-11-12 14:29 UTC (permalink / raw)
To: devel, gaoliming, gechao; +Cc: dandan.bi, eric.dong
Create PR https://github.com/tianocore/edk2/pull/1120
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67336+4905953+8761045@groups.io
> <bounce+27952+67336+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年11月12日 9:40
> 收件人: gechao@greatwall.com.cn; devel@edk2.groups.io
> 抄送: dandan.bi@intel.com; eric.dong@intel.com
> 主题: [edk2-devel] 回复: [PATCH] MdeModulePkg DisplayEngineDxe: Correct
> the local variable name.
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: gechao@greatwall.com.cn <gechao@greatwall.com.cn>
> > 发送时间: 2020年11月12日 9:34
> > 收件人: devel@edk2.groups.io
> > 抄送: dandan.bi@intel.com; eric.dong@intel.com;
> > gaoliming@byosoft.com.cn; gechao <gechao@greatwall.com.cn>
> > 主题: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable
> > name.
> >
> > From: gechao <gechao@greatwall.com.cn>
> >
> > Signed-off-by: gechao <gechao@greatwall.com.cn>
> > ---
> > .../Universal/DisplayEngineDxe/FormDisplay.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > index 3b034a1c82..a3898dc2ec 100644
> > --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > @@ -372,7 +372,7 @@ GetWidth (
> > {
> >
> > CHAR16 *String;
> >
> > UINTN Size;
> >
> > - EFI_IFR_TEXT *TestOp;
> >
> > + EFI_IFR_TEXT *TextOp;
> >
> > UINT16 ReturnWidth;
> >
> > FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> >
> >
> >
> > @@ -394,9 +394,9 @@ GetWidth (
> > // See if the second text parameter is really NULL
> >
> > //
> >
> > if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> >
> > - TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > - if (TestOp->TextTwo != 0) {
> >
> > - String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> >
> > + TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > + if (TextOp->TextTwo != 0) {
> >
> > + String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> >
> > Size = StrLen (String);
> >
> > FreePool (String);
> >
> > }
> >
> > @@ -2166,7 +2166,7 @@ HasOptionString (
> > FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> >
> > CHAR16 *String;
> >
> > UINTN Size;
> >
> > - EFI_IFR_TEXT *TestOp;
> >
> > + EFI_IFR_TEXT *TextOp;
> >
> >
> >
> > Size = 0;
> >
> > Statement = MenuOption->ThisTag;
> >
> > @@ -2175,9 +2175,9 @@ HasOptionString (
> > // See if the second text parameter is really NULL
> >
> > //
> >
> > if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> >
> > - TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > - if (TestOp->TextTwo != 0) {
> >
> > - String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> >
> > + TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > + if (TextOp->TextTwo != 0) {
> >
> > + String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> >
> > Size = StrLen (String);
> >
> > FreePool (String);
> >
> > }
> >
> > --
> > 2.28.0.windows.1
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-12 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 1:33 [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name gechao
2020-11-12 1:39 ` 回复: " gaoliming
[not found] ` <16469F0A5D9CED83.27022@groups.io>
2020-11-12 14:29 ` 回复: [edk2-devel] " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox