From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.4229.1571748233615678661 for ; Tue, 22 Oct 2019 05:43:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZtWxGTe+; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571748232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gKm/+0TLtcOdAWx1759K627ocQCQRt+H0KVFhxGQ770=; b=ZtWxGTe+8jSJyES431fnkWAeIaHKQCJtfAbCFq51voYwzFhx2RWV6Uo0fXxlULW86S0xf4 nTwSiT/1WDDQHJfMkexAnTeqGnmf34Y1xQE/YEFU18itCW/vvJJKOSbX1xhBwlPNmGeFP1 9VFq/sYRN3Fvn2se88st7Us2KcCR0bw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-DHjhYwnyPDi91XXtkh51yA-1; Tue, 22 Oct 2019 08:43:51 -0400 Received: by mail-wr1-f69.google.com with SMTP id v8so8208101wrt.16 for ; Tue, 22 Oct 2019 05:43:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M5+U7X5vs5HMF/dQHbuR+draPCc0fdTB/bjqFR8atPU=; b=gWp6rKx5OMEt5qCKhA957PPecZIaMHgY/uTcDIqz0dPehiMnguCf51scybkAnIzFjN 9n4Xiib53Vob+y4UjRzJKdPWw9IdsLOmwkt+kM9x/aU1zfgn3lQMwS0sWUjNQP+P4DLL 57BDpoArqmc4Q3oDgx7Hnup+0V6yrbs/FeybzaRQw/c7YIUNNZ46SkyAgen8kou/jzJC G1W2KzsK3avyPwBDSN95SjSmsGrRhLqxGWF7W40E7oxpUe2fk+w6JuItKrCItCAGujuw nCPy0op7S7T1j/JMeWZuf6ByUnwxIol0usqJyZ77duAegjcOujcimhHq7huI2S75OJWE TFuQ== X-Gm-Message-State: APjAAAU1Nvs2/HYoCA1OW2lPHSqoizBRuDuLm02W9j2FE0ZCBSn1I6O9 fJj6eRcsqYOM4WsmpgIFgOmRcPs2BpKcis2tm9ecocq6lJl6xAsvi0TKvLQPPZJc9aCYlb9EGhI TG/WixMt6NbhhCw== X-Received: by 2002:adf:e292:: with SMTP id v18mr3323206wri.190.1571748229015; Tue, 22 Oct 2019 05:43:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3cRU7jpVoYGuj+2PkJQiwFj6VVmW3wp2hSmFzF9dCcK0rrM8BYE19VAmV+QnpO2I7yITtrg== X-Received: by 2002:adf:e292:: with SMTP id v18mr3323180wri.190.1571748228628; Tue, 22 Oct 2019 05:43:48 -0700 (PDT) Return-Path: Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id y1sm21413084wrw.6.2019.10.22.05.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 05:43:48 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] FmpDevicePkg: Fix spelling errors To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Liming Gao References: <20191018202445.23596-1-michael.d.kinney@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <81382627-fc10-01ba-d67b-0c4cb8ed97a4@redhat.com> Date: Tue, 22 Oct 2019 14:43:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191018202445.23596-1-michael.d.kinney@intel.com> X-MC-Unique: DHjhYwnyPDi91XXtkh51yA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/18/19 10:24 PM, Michael D Kinney wrote: > From: Sean Brogan >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2262 >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Signed-off-by: Michael D Kinney > --- > .../CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c | 4 ++-- > .../CapsuleUpdatePolicyDxe.inf | 2 +- > FmpDevicePkg/FmpDevicePkg.dec | 4 ++-- > FmpDevicePkg/FmpDevicePkg.dsc | 2 +- > FmpDevicePkg/FmpDevicePkg.uni | 2 +- > FmpDevicePkg/FmpDxe/FmpDxe.c | 12 ++++++------ > FmpDevicePkg/Include/Library/FmpDeviceLib.h | 4 ++-- > .../CapsuleUpdatePolicyLibOnProtocol.c | 2 +- > .../CapsuleUpdatePolicyLibOnProtocol.inf | 2 +- > FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c | 4 ++-- > .../PrivateInclude/Protocol/CapsuleUpdatePolicy.h | 2 +- > 11 files changed, 20 insertions(+), 20 deletions(-) >=20 > diff --git a/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c= b/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c > index d2571fd0e6..1035fd67dd 100644 > --- a/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c > +++ b/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c > @@ -161,10 +161,10 @@ CapsuleUpdatePolicyInitialize ( > { > EFI_STATUS Status; > =20 > - ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gEdkiiCapuleUpdatePolicyProt= ocolGuid); > + ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gEdkiiCapsuleUpdatePolicyPro= tocolGuid); > Status =3D gBS->InstallMultipleProtocolInterfaces ( > &mHandle, > - &gEdkiiCapuleUpdatePolicyProtocolGuid, &mCapsuleUpdate= Policy, > + &gEdkiiCapsuleUpdatePolicyProtocolGuid, &mCapsuleUpdat= ePolicy, > NULL > ); > ASSERT_EFI_ERROR (Status); > diff --git a/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.i= nf b/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf > index d168780eb9..5ed7086b91 100644 > --- a/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf > +++ b/FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf > @@ -39,7 +39,7 @@ [LibraryClasses] > CapsuleUpdatePolicyLib > =20 > [Protocols] > - gEdkiiCapuleUpdatePolicyProtocolGuid ## PRODUCES > + gEdkiiCapsuleUpdatePolicyProtocolGuid ## PRODUCES > =20 > [Depex] > TRUE > diff --git a/FmpDevicePkg/FmpDevicePkg.dec b/FmpDevicePkg/FmpDevicePkg.de= c > index 8312b7cb22..55671878dd 100644 > --- a/FmpDevicePkg/FmpDevicePkg.dec > +++ b/FmpDevicePkg/FmpDevicePkg.dec > @@ -50,12 +50,12 @@ [Guids] > =20 > [Protocols.Common.Private] > ## Capsule Update Policy Protocol > - gEdkiiCapuleUpdatePolicyProtocolGuid =3D { 0x487784c5, 0x6299, 0x4ba6,= { 0xb0, 0x96, 0x5c, 0xc5, 0x27, 0x7c, 0xf7, 0x57 } } > + gEdkiiCapsuleUpdatePolicyProtocolGuid =3D { 0x487784c5, 0x6299, 0x4ba6= , { 0xb0, 0x96, 0x5c, 0xc5, 0x27, 0x7c, 0xf7, 0x57 } } > =20 > [PcdsFeatureFlag] > ## Indicates if the Firmware Management Protocol supports access to > # to a firmware storage device. If set to FALSE, then only GetImage= Info() > - # is supported. This is used by FMP drivers that require the samlles= t > + # is supported. This is used by FMP drivers that require the smalles= t > # possible Firmware Management Protocol implementation that supports > # advertising the updatable firmware device in the ESRT.
> # TRUE - All Firmware Management Protocol services supported.
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.ds= c > index bf283b93ea..67b5aa7a32 100644 > --- a/FmpDevicePkg/FmpDevicePkg.dsc > +++ b/FmpDevicePkg/FmpDevicePkg.dsc > @@ -60,7 +60,7 @@ [LibraryClasses] > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > # It is not possible to prevent the ARM compiler for generic intrinsi= c functions. > - # This library provides the instrinsic functions generate by a given c= ompiler. > + # This library provides the intrinsic functions generate by a given co= mpiler. > # [LibraryClasses.ARM, LibraryClasses.AARCH64] and NULL mean link thi= s library > # into all ARM and AARCH64 images. > # > diff --git a/FmpDevicePkg/FmpDevicePkg.uni b/FmpDevicePkg/FmpDevicePkg.un= i > index 9e21130fae..263f88078b 100644 > --- a/FmpDevicePkg/FmpDevicePkg.uni > +++ b/FmpDevicePkg/FmpDevicePkg.uni > @@ -19,7 +19,7 @@ > #string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDeviceStorageAccessEnable= _PROMPT #language en-US "Firmware Device Storage Access Enabled." > #string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDeviceStorageAccessEnable= _HELP #language en-US "Indicates if the Firmware Management Protocol sup= ports access to" > = "to a firmware storage device. If set to FALSE, t= hen only GetImageInfo()" > - = "is supported. This is used by FMP drivers that re= quire the samllest" > + = "is supported. This is used by FMP drivers that re= quire the smallest" > = "possible Firmware Management Protocol implementat= ion that supports" > = "advertising the updatable firmware device in the = ESRT.
" > = " TRUE - All Firmware Management Protocol servic= es supported.
" > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c > index 3ca9d3526a..fe465af11e 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -963,7 +963,7 @@ SetTheImage ( > VOID *FmpHeader; > UINTN FmpPayloadSize; > UINT32 AllHeaderSize; > - UINT32 IncommingFwVersion; > + UINT32 IncomingFwVersion; > UINT32 LastAttemptStatus; > UINT32 Version; > UINT32 LowestSupportedVersion; > @@ -975,7 +975,7 @@ SetTheImage ( > FmpHeader =3D NULL; > FmpPayloadSize =3D 0; > AllHeaderSize =3D 0; > - IncommingFwVersion =3D 0; > + IncomingFwVersion =3D 0; > LastAttemptStatus =3D LAST_ATTEMPT_STATUS_ERROR_UNSUCCESSFUL; > =20 > if (!FeaturePcdGet (PcdFmpDeviceStorageAccessEnable)) { > @@ -996,7 +996,7 @@ SetTheImage ( > // > // Set to 0 to clear any previous results. > // > - SetLastAttemptVersionInVariable (Private, IncommingFwVersion); > + SetLastAttemptVersionInVariable (Private, IncomingFwVersion); > =20 > // > // if we have locked the device, then skip the set operation. > @@ -1030,12 +1030,12 @@ SetTheImage ( > Status =3D EFI_ABORTED; > goto cleanup; > } > - Status =3D GetFmpPayloadHeaderVersion (FmpHeader, FmpPayloadSize, &Inc= ommingFwVersion); > + Status =3D GetFmpPayloadHeaderVersion (FmpHeader, FmpPayloadSize, &Inc= omingFwVersion); > if (!EFI_ERROR (Status)) { > // > // Set to actual value > // > - SetLastAttemptVersionInVariable (Private, IncommingFwVersion); > + SetLastAttemptVersionInVariable (Private, IncomingFwVersion); > } > =20 > =20 > @@ -1158,7 +1158,7 @@ SetTheImage ( > ImageSize - AllHeaderSize, > VendorCode, > FmpDxeProgress, > - IncommingFwVersion, > + IncomingFwVersion, > AbortReason > ); > if (EFI_ERROR (Status)) { > diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h b/FmpDevicePkg/I= nclude/Library/FmpDeviceLib.h > index 1e498c13ce..9a89f5c2ee 100644 > --- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h > +++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h > @@ -89,7 +89,7 @@ RegisterFmpInstaller ( > Protocol. > =20 > @retval EFI_SUCCESS The device is managed by a driver that follo= ws the > - UEFI Driver Model. FmpUinstaller must be cal= led on > + UEFI Driver Model. FmpUninstaller must be ca= lled on > each Driver Binding Stop(). > @retval EFI_UNSUPPORTED The device is not managed by a driver that f= ollows > the UEFI Driver Model. > @@ -321,7 +321,7 @@ FmpDeviceGetVersion ( > device. > =20 > @retval EFI_SUCCESS The hardware instance for the current firmw= are > - devide is returned in HardwareInstance. > + device is returned in HardwareInstance. Nice. Reviewed-by: Philippe Mathieu-Daude > @retval EFI_UNSUPPORTED The firmware device does not support a meth= od to > report the hardware instance value. > @retval EFI_DEVICE_ERROR An error occurred attempting to retrieve th= e hardware > diff --git a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/Capsul= eUpdatePolicyLibOnProtocol.c b/FmpDevicePkg/Library/CapsuleUpdatePolicyLibO= nProtocol/CapsuleUpdatePolicyLibOnProtocol.c > index 2c7c37fa92..6f916888c7 100644 > --- a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdate= PolicyLibOnProtocol.c > +++ b/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdate= PolicyLibOnProtocol.c > @@ -37,7 +37,7 @@ LookupCapsuleUpdatePolicyProtocol ( > return TRUE; > } > Status =3D gBS->LocateProtocol ( > - &gEdkiiCapuleUpdatePolicyProtocolGuid, > + &gEdkiiCapsuleUpdatePolicyProtocolGuid, > NULL, > (VOID **)&mCapsuleUpdatePolicy > ); > diff --git a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/Capsul= eUpdatePolicyLibOnProtocol.inf b/FmpDevicePkg/Library/CapsuleUpdatePolicyLi= bOnProtocol/CapsuleUpdatePolicyLibOnProtocol.inf > index 042daaabce..a56b836d22 100644 > --- a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdate= PolicyLibOnProtocol.inf > +++ b/FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdate= PolicyLibOnProtocol.inf > @@ -37,4 +37,4 @@ [LibraryClasses] > UefiBootServicesTableLib > =20 > [Protocols] > - gEdkiiCapuleUpdatePolicyProtocolGuid ## CONSUMES > + gEdkiiCapsuleUpdatePolicyProtocolGuid ## CONSUMES > diff --git a/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c b/FmpDe= vicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c > index fd219cb70b..316de12e91 100644 > --- a/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c > +++ b/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c > @@ -50,7 +50,7 @@ RegisterFmpInstaller ( > Protocol. > =20 > @retval EFI_SUCCESS The device is managed by a driver that follo= ws the > - UEFI Driver Model. FmpUinstaller must be cal= led on > + UEFI Driver Model. FmpUninstaller must be ca= lled on > each Driver Binding Stop(). > @retval EFI_UNSUPPORTED The device is not managed by a driver that f= ollows > the UEFI Driver Model. > @@ -319,7 +319,7 @@ FmpDeviceGetVersion ( > device. > =20 > @retval EFI_SUCCESS The hardware instance for the current firmw= are > - devide is returned in HardwareInstance. > + device is returned in HardwareInstance. > @retval EFI_UNSUPPORTED The firmware device does not support a meth= od to > report the hardware instance value. > @retval EFI_DEVICE_ERROR An error occurred attempting to retrieve th= e hardware > diff --git a/FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h b= /FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h > index 871f0a1854..4f7d917295 100644 > --- a/FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h > +++ b/FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h > @@ -127,6 +127,6 @@ struct _EDKII_CAPSULE_UPDATE_POLICY_PROTOCOL { > EDKII_CAPSULE_UPDATE_POLICY_IS_FMP_DEVICE_AT_LOCK_EVENT_REQUIRED = IsLockFmpDeviceAtLockEventGuidRequired; > }; > =20 > -extern EFI_GUID gEdkiiCapuleUpdatePolicyProtocolGuid; > +extern EFI_GUID gEdkiiCapsuleUpdatePolicyProtocolGuid; > =20 > #endif >=20