From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.2446.1613005569109625543 for ; Wed, 10 Feb 2021 17:06:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=e8YHbvO3; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [131.107.174.202]) by linux.microsoft.com (Postfix) with ESMTPSA id B312520B6C40; Wed, 10 Feb 2021 17:06:08 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B312520B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1613005568; bh=Y96wctB8gj+kttMevf9kA4EZHFEj+4w7Rr/d4l/mKp8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=e8YHbvO30kNn/peW03vMs/O+JMsO+L6tJvqNXYFXhsBm37pj8PfydtoKwFUuMI+am qXo0/YE4xuDvimSwIdMYam/73vc8mJBPT/ObjVIUyrbJScfWOsU5vPKPc3oIakqVdA 4jzvV2mzSND26DkrIJJ29q5ky0mOK/7Vk7tz/Xys= Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Add X64 build support To: devel@edk2.groups.io, ardb@kernel.org Cc: Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh References: <20210203035415.514-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" Message-ID: <813886ce-a51c-f0b0-9cac-680cac869d97@linux.microsoft.com> Date: Wed, 10 Feb 2021 17:06:09 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I updated the patch with your new email in V2. Thanks, Michael On 2/10/2021 2:31 PM, Ard Biesheuvel wrote: > On Wed, 3 Feb 2021 at 04:54, wrote: >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 >> >> Several libraries have been added to the package to support X64 but >> the package itself does not support X64. This modifies the DSC to >> enable X64 build. >> >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Jiewen Yao >> Cc: Supreeth Venkatesh >> Signed-off-by: Michael Kubacki >> --- >> StandaloneMmPkg/StandaloneMmPkg.dsc | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc >> index a566724c88ab..73f3f0f6b1cd 100644 >> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc >> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc >> @@ -3,6 +3,7 @@ >> # >> # Copyright (c) 2015, Intel Corporation. All rights reserved.
>> # Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
>> +# Copyright (C) Microsoft Corporation
>> # >> # SPDX-License-Identifier: BSD-2-Clause-Patent >> # >> @@ -19,7 +20,7 @@ [Defines] >> PLATFORM_VERSION = 1.0 >> DSC_SPECIFICATION = 0x00010011 >> OUTPUT_DIRECTORY = Build/StandaloneMm >> - SUPPORTED_ARCHITECTURES = AARCH64 >> + SUPPORTED_ARCHITECTURES = AARCH64|X64 >> BUILD_TARGETS = DEBUG|RELEASE >> SKUID_IDENTIFIER = DEFAULT >> >> @@ -37,6 +38,7 @@ [LibraryClasses] >> # >> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> + CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf >> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf >> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf >> ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf >> @@ -47,7 +49,7 @@ [LibraryClasses] >> MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf >> MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> - PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf >> + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf >> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf >> @@ -60,6 +62,7 @@ [LibraryClasses.AARCH64] >> StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf >> ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf >> CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf >> + PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf >> >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> @@ -110,11 +113,11 @@ [Components.common] >> StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf >> StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf >> StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf >> - StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf >> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf >> >> [Components.AARCH64] >> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf >> + StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf >> >> ################################################################################################### >> # >> @@ -128,3 +131,7 @@ [Components.AARCH64] >> [BuildOptions.AARCH64] >> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp -mstrict-align >> GCC:*_*_*_CC_FLAGS = -mstrict-align >> + >> +[BuildOptions.X64] >> + MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 >> + GCC:*_GCC*_*_DLINK_FLAGS = -z common-page-size=0x1000 >> -- >> 2.28.0.windows.1 >> >> > > This one does not apply either. Perhaps it got mangled because I only > received it via the mailing list rather than directly via CC? > > > >