Re: [PATCH 3/6] OvmfPkg/ResetSystemLib: improve coding style in ResetSystem()

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/17/20 5:37 PM, Laszlo Ersek wrote:
> The cases under ResetSystem() currently mix "break"s with "return"s for no
> good reason. Use "break" consistently.
> 
> (The inconsistency was introduced in commit 84c0b80de716,
> "OvmfPkg/ResetSystemLib: Add new API ResetSystem", 2019-04-28.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 23816183a953..0fc142325ece 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -157,13 +157,13 @@ ResetSystem (
>   
>     case EfiResetShutdown:
>       ResetShutdown ();
> -    return;
> +    break;
>   
>     case EfiResetPlatformSpecific:
>       ResetPlatformSpecific (DataSize, ResetData);
> -    return;
> +    break;
>   
>     default:
> -    return;
> +    break;
>     }
>   }
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>