From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id E94691A1EC4
 for <edk2-devel@ml01.01.org>; Fri, 14 Oct 2016 05:22:19 -0700 (PDT)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 822EA81222;
 Fri, 14 Oct 2016 12:22:19 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-51.phx2.redhat.com
 [10.3.116.51])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u9ECMIbM021341; Fri, 14 Oct 2016 08:22:18 -0400
To: Liming Gao <liming.gao@intel.com>, edk2-devel@ml01.01.org
References: <1476427653-13184-1-git-send-email-liming.gao@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <8168a43b-1b66-6697-eeb5-41b431af15ee@redhat.com>
Date: Fri, 14 Oct 2016 14:22:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1476427653-13184-1-git-send-email-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.25]); Fri, 14 Oct 2016 12:22:19 +0000 (UTC)
Subject: Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Oct 2016 12:22:20 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 10/14/16 08:47, Liming Gao wrote:
> Remove extra qword in nasm code to make it pass build.
> This file is only built in INTEL ICC compiler. So, there is missing
> build check for it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> index ee63ff7..206de40 100644
> --- a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> +++ b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
>      mov     edx, [esp + 20]
>      mov     ebx, [esp + 24]
>      mov     ecx, [esp + 28]
> -    lock    cmpxchg8b   qword [esi]
> +    lock    cmpxchg8b [esi]
>      pop     ebx
>      pop     esi
>      ret
> 

Suggested subject line:

MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC build

(73 characters)

Thanks,
Laszlo